Fix WorkflowExecutor initialization error (E0599)#1582
Open
yabhimanyu2007-sys wants to merge 2 commits intomofa-org:mainfrom
Open
Fix WorkflowExecutor initialization error (E0599)#1582yabhimanyu2007-sys wants to merge 2 commits intomofa-org:mainfrom
yabhimanyu2007-sys wants to merge 2 commits intomofa-org:mainfrom
Conversation
ea17b75 to
2c797ad
Compare
Contributor
|
Hey @yangrudan @lijingrs, could you please review this PR? It fixes a WorkflowExecutor initialization error (E0599) that likely affects users. Thanks! 👀 |
Author
|
Reproduction While building the project, I encountered a compilation error: error[E0599]: no function or associated item named This occurs where "WorkflowExecutor::default()" is used. Fix Replaced "WorkflowExecutor::default()" with "WorkflowExecutor::new()", which aligns with the current API. Verification
Please let me know if this change aligns with the intended usage or if additional adjustments/tests are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a compilation error caused by the use of
WorkflowExecutor::default()which is not implemented.Changes
WorkflowExecutor::default()withWorkflowExecutor::new(ExecutorConfig::default())Context
The previous implementation attempted to call a non-existent
default()method onWorkflowExecutor, leading to Rust error E0599.Result
How to Test
cargo buildcargo testBreaking Changes
Notes
This change aligns with the current design of
WorkflowExecutorand ensures compatibility with the existing API.