Skip to content

main #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohitb117 merged 4 commits into from
Jan 29, 2026
Merged

main #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a152507
remove the keys
mohitb-117 Jan 27, 2026
352f013
remove un-necessary classes
mohitb-117 Jan 28, 2026
e885fdf
add support for pull to refresh
mohitb-117 Jan 28, 2026
c20a183
extracted the common card ui into a separate container
mohitb-117 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 53 additions & 27 deletions app/src/main/java/com/mohitb117/demo_omdb_api/activities/LaunchingActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@file:OptIn(ExperimentalMaterial3Api::class)

package com.mohitb117.demo_omdb_api.activities

import android.os.Bundle
Expand All @@ -7,37 +9,42 @@ import androidx.activity.enableEdgeToEdge
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.statusBars
import androidx.compose.foundation.layout.windowInsetsPadding
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text
import androidx.compose.material3.adaptive.navigationsuite.NavigationSuiteScaffold
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import androidx.lifecycle.viewmodel.compose.viewModel
import com.mohitb117.demo_omdb_api.activities.ui.theme.DEMO_OMDB_APITheme
import com.mohitb117.demo_omdb_api.activities.ui.theme.Purple80
import com.mohitb117.demo_omdb_api.datamodels.SearchResult
import com.mohitb117.demo_omdb_api.datamodels.SearchResultsBody
import com.mohitb117.demo_omdb_api.ui.favourites.FavouritesViewModel
import com.mohitb117.demo_omdb_api.ui.search.FavouritesComposableContent
import com.mohitb117.demo_omdb_api.ui.favourites.FavouritesComposableContent
import com.mohitb117.demo_omdb_api.ui.search.Result
import com.mohitb117.demo_omdb_api.ui.search.SearchComposableContent
import com.mohitb117.demo_omdb_api.ui.search.SearchViewModel
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.delay

@AndroidEntryPoint
class LaunchingActivity : ComponentActivity() {
Expand All @@ -62,13 +69,18 @@ class LaunchingActivity : ComponentActivity() {
) {
val searchUiState by searchViewModel.searchResultsViewState.collectAsStateWithLifecycle()
val favouritesUiState by favouritesViewModel.favouritedIdsFlow.collectAsStateWithLifecycle()
val searchQuery by searchViewModel.searchQuery.collectAsStateWithLifecycle()
val isRefreshing by searchViewModel.isRefreshing.collectAsStateWithLifecycle()

LaunchComposableContent(
modifier = modifier,
searchUiState = searchUiState,
favouritesUiState = favouritesUiState,
onSearch = { searchViewModel.loadSearchResult(it) },
isMovieFavourited = { searchViewModel.favouritedIds.value.contains(it) },
searchQuery = searchQuery,
onRefresh = { searchViewModel.refresh() },
isRefreshing = isRefreshing,
onSearchQueryChanged = { searchViewModel.onSearchQueryChanged(it) },
isMovieFavourited = { searchViewModel.favouritedIds.value.any { fav -> fav.imdbID == it.imdbID } },
onToggleMovieFavorited = { searchViewModel.toggleFavourite(it) },
)
}
Expand All @@ -78,7 +90,10 @@ class LaunchingActivity : ComponentActivity() {
modifier: Modifier = Modifier,
searchUiState: Result<SearchResultsBody>,
favouritesUiState: Set<SearchResult>,
onSearch: (String) -> Unit,
searchQuery: String,
isRefreshing: Boolean = false,
onRefresh: () -> Unit = {},
onSearchQueryChanged: (String) -> Unit,
isMovieFavourited: (SearchResult) -> Boolean = { false },
onToggleMovieFavorited: suspend (SearchResult) -> Boolean = { false },
) {
Expand All @@ -97,41 +112,48 @@ class LaunchingActivity : ComponentActivity() {
onClick = { currentDestination = it },
)
}
}
) {
var searchQuery by rememberSaveable { mutableStateOf("") }
}) {
val searchResultError = (searchUiState as? Result.Failure)?.error

Scaffold(
modifier = Modifier.fillMaxSize(),
topBar = {
Text(
modifier = Modifier
.fillMaxWidth()
.windowInsetsPadding(WindowInsets.statusBars)
.padding(horizontal = 16.dp, vertical = 8.dp),
text = searchResultError?.localizedMessage ?: stringResource(currentDestination.label),
color = if (searchResultError != null) Color.Red else Color.Unspecified,
)
},
bottomBar = {
if (currentDestination == AppDestinations.HOME) {
OutlinedTextField(
modifier = Modifier
.fillMaxWidth()
.background(color = Color.Gray),
.background(color = Purple80),
value = searchQuery,
onValueChange = { searchQuery = it },
label = { Text(text = "Search Movie!") }
)
onValueChange = { onSearchQueryChanged(it) },
label = { Text(text = "Search Movie!") })
}
}
) { innerPadding ->
when (currentDestination) {
AppDestinations.HOME -> {
SearchMovieInfoLayout(
name = stringResource(currentDestination.label),
modifier = Modifier.padding(innerPadding),
searchQuery = searchQuery,
searchUiState = searchUiState,
onSearch = onSearch,
isRefreshing = isRefreshing,
onRefresh = onRefresh,
isMovieFavourited = isMovieFavourited,
onToggleMovieFavorited = onToggleMovieFavorited,
)
}

else -> {
FavouritesComposableLayout(
name = stringResource(currentDestination.label),
modifier = Modifier.padding(innerPadding),
uiState = favouritesUiState,
isMovieFavourited = isMovieFavourited,
Expand All @@ -145,11 +167,11 @@ class LaunchingActivity : ComponentActivity() {

@Composable
fun SearchMovieInfoLayout(
name: String,
modifier: Modifier = Modifier,
searchQuery: String = "",
searchUiState: Result<SearchResultsBody>,
onSearch: (String) -> Unit,
isRefreshing: Boolean = false,
onRefresh: () -> Unit = {},
isMovieFavourited: (SearchResult) -> Boolean = { false },
onToggleMovieFavorited: suspend (SearchResult) -> Boolean = { false },
) {
Expand All @@ -160,17 +182,23 @@ class LaunchingActivity : ComponentActivity() {
) {

if (searchQuery.isNotEmpty()) {
LaunchedEffect(searchQuery) {
delay(500) // Debounce for 500ms
onSearch(searchQuery)
val effectiveUiState = when {
searchUiState is Result.Failure && searchUiState.lastCachedData != null -> {
Result.Success(searchUiState.lastCachedData, searchQuery)
}

else -> searchUiState
}

SearchComposableContent(
modifier = Modifier,
searchUiState = searchUiState,
searchUiState = effectiveUiState,
onRefresh = onRefresh,
isRefreshing = isRefreshing,
onToggleMovieFavorited = onToggleMovieFavorited,
isMovieFavourited = isMovieFavourited,
)

} else {
Text("Nothing to search right now!")
}
Expand All @@ -179,7 +207,6 @@ class LaunchingActivity : ComponentActivity() {

@Composable
fun FavouritesComposableLayout(
name: String,
uiState: Set<SearchResult>,
modifier: Modifier = Modifier,
isMovieFavourited: (SearchResult) -> Boolean = { false },
Expand All @@ -205,9 +232,7 @@ class LaunchingActivity : ComponentActivity() {
fun SearchMovieInfoLayoutPreview() {
DEMO_OMDB_APITheme {
SearchMovieInfoLayout(
name = "Android",
searchUiState = Result.Loading(""),
onSearch = {}
searchUiState = Result.Loading("")
)
}
}
Expand All @@ -219,7 +244,8 @@ class LaunchingActivity : ComponentActivity() {
LaunchComposableContent(
searchUiState = Result.Loading(""),
favouritesUiState = emptySet(),
onSearch = {}
searchQuery = "",
onSearchQueryChanged = {}
)
}
}
Expand Down
Loading