Added a watch on 'open' for dynamic open changes#41
Open
tysenmoore-xse wants to merge 8 commits intomohsen1:masterfrom
Open
Added a watch on 'open' for dynamic open changes#41tysenmoore-xse wants to merge 8 commits intomohsen1:masterfrom
tysenmoore-xse wants to merge 8 commits intomohsen1:masterfrom
Conversation
Owner
|
For this a simple scope.$watch('open', function(value) { scope.isOpen = !!value; }); |
Author
|
I only modified the src version, I was unclear if the dist version was generated as well as the minified versions. Let me know if there is more integration needed. |
Author
|
I treated it as a singleton because I was not sure if the watch would be added on every link phase. If you'd prefer I could remove the singleton approach. |
Owner
|
The singleton won't help much here. |
- Changed open watch to no longer be a singleton
|
any update on this? Dynamic open attr would be fantastic |
Owner
|
My plan is to use json-formatter-js for internally in this directive (#35) . That will make this directive a thin wrapper around the core lib. If you have time to do it I'll help merging and releasing it. |
added 5 commits
August 22, 2016 10:53
…eper) objects" This reverts commit f4c4927.
…ecial work needed - Added branch specific tests section to the demo.html to easily test the branch features
…tion to the decimal value
|
Any chance we can have the watched open attribute? Whats the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to implement #34. I am a little green at some of this stuff so this may not be the best approach. I tested the changes with simple collapse all/none buttons and they seemed to work well--redrew the content when a button was pressed.