Bundle remaining XStatic dependencies#2214
Merged
RogerHaase merged 9 commits intomoinwiki:masterfrom Mar 30, 2026
Merged
Conversation
…g_resources workaround)
roland-ruedenauer
force-pushed
the
xstatic
branch
from
fee546e to
cc5eb61
Compare
* add field 'itemtype' when saving an item in TarMixin.put_member * adjust unit tests: always pass 'itemtype' with item metadata
… when it is already present * an unnecessary reload causes any modifications made to the metadata to be discarded * this is also a minor performance improvement
The svgedit distribution sources were retrieved using * npm -i svgedit * rm -rf src/moin/xstatic/svgedit_moin/* * cp -r -p node_modules/svgedit/dist/editor src/moin/xstatic/svgedit_moin/ Sources copied from svgedit 7.4.1 were not modified. svgedit 7.x must be used as ESM module. The file 'svgeditor.js' creating the editor is imported as module script in 'base.html'. The svgedit extension 'ext-moin2' handles interfacing with Moin2. Executing 'Save' from the editor menu will pass svg and png content to Moin2 via a form POST. The extension also prevents displaying a browser dialog on form submission after saving the svg. Some noteworthy changes applied to the Moin code * pass fully qualified item names to svgedit (namespace was missing before) * change arguments of ContentMixin.put_member; this also resolved issues resulting from always opening the temporary tarfile in append mode. * return redirect after handling POST request
roland-ruedenauer
force-pushed
the
xstatic
branch
from
cc5eb61 to
2dbc7b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle the remaining 3 XStatic dependencies and upgrade svgedit to version 7.4.1
setuptools(getting rid ofpkg_resourcesworkaroundwikiconfig.pymust be changed (import and use ofget_xstatic_module_path_map)