Add TRUSTED_HOSTS to Flask config in wikiconfig.py and related docs#2217
Open
UlrichB22 wants to merge 3 commits intomoinwiki:masterfrom
Open
Add TRUSTED_HOSTS to Flask config in wikiconfig.py and related docs#2217UlrichB22 wants to merge 3 commits intomoinwiki:masterfrom
UlrichB22 wants to merge 3 commits intomoinwiki:masterfrom
Conversation
|
|
||
|
|
||
| @frontend.errorhandler(BadRequest) | ||
| def bad_request(error): |
Contributor
There was a problem hiding this comment.
Having this error handler in app.py would seem more reasonable to me. All the frontend views are bundled in a blueprint. Better let's keep the separation and not break it for error handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to prevent Host Name Vulnerability.
In production deployments,
TRUSTED_HOSTSmust be configured correctly. Otherwise, when generating absolute links for password reset, email verification, or similar flows, the application may trust unvalidated Host values, which can cause links in outgoing emails to point to an incorrect or attacker-controlled domain. Using a hostname in the request URL that is not inTRUSTED_HOSTSmay lead to a "HTTP 400 - Bad Request"-Error with a message like"Host <hostname> is not trusted.".