fix: replace allowlisted vulnerabilities with npm overrides#189
Merged
Conversation
- Added axios@1.13.5 override to fix GHSA-43fc-jf86-j433 (DoS) - Added lodash@4.17.23 and lodash-es@4.17.23 overrides to fix GHSA-xxjr-mmjv-4gpg (prototype pollution) - Removed GHSA-43fc-jf86-j433 and GHSA-xxjr-mmjv-4gpg from audit-ci allowlist - Only GHSA-2g4f-4pwh-qvx6 (ajv) remains allowlisted as it cannot be overridden without breaking standard@17 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gibaros
requested review from
bushjames,
elnyry-sam-k,
kleyow,
oderayi,
shashi165 and
vijayg10
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axios@1.13.5override to fix GHSA-43fc-jf86-j433 (axios DoS vulnerability)lodash@4.17.23andlodash-es@4.17.23overrides to fix GHSA-xxjr-mmjv-4gpg (prototype pollution)audit-ci.jsoncallowlist — onlyGHSA-2g4f-4pwh-qvx6(ajv ReDoS) remains as it genuinely cannot be overridden without breakingstandard@17Context
PR #188 incorrectly allowlisted these vulnerabilities instead of fixing them with npm overrides. This PR corrects that by applying proper overrides for the patched versions.
Test plan
npm run audit:checkpasses (only ajv allowlisted)npm ls axiosshows 1.13.5 everywherenpm ls lodash-esshows 4.17.23 (overridden from 4.17.21)🤖 Generated with Claude Code