Exclude integration test artifacts from source-release.zip #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test
target/directories created during release builds were being included in the source-release.zip, as reported in the reproducible builds analysis.Changes
src/test/tosrc/test/resources/getTestResourcePath()helper method inAbstractXmlMojoTestCaseto reference tests viatarget/test-classes/ValidateMojoTestandTransformMojoTestto use the new helper methodsrc/test/multimodule/xsd-import/validation/src/main/resources/xmlto point to new locationThis ensures that when integration tests run during release builds and create
target/directories, those artifacts are created undertarget/test-classes/(which is excluded from source releases) rather than undersrc/test/(which would be included). Source releases now contain only source files, not build artifacts likesrc/test/it4/target/generated-resources/xml/xslt/doc1.xml.Original prompt
<issue_description>discovered while rebuilding 1.1.0 and 1.2.0 for Reproducible Builds: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/codehaus/mojo/xml-maven-plugin/README.md
for example
src/test/it4/target/generated-resources/xml/xslt/doc1.xmlsee full https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/codehaus/mojo/xml-maven-plugin/xml-maven-plugin-1.1.0.diffoscope</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.