Allows connection to daemonized vw#14
Open
robinsonkwame wants to merge 4 commits intomokelly:masterfrom
Open
Conversation
Allow VW() instances to connect to existing VW daemons
`active_learning` is not a valid `vw` option, but `active` is. Somewhat redundant since this fork mainly focuses on connecting to already deamonized `vw` but it's all good.
Revise to launch a new process if command is given, irregardless if an ip was given or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily allows connections to a deamonized vw if an ip and port are only given. The current repo also has an older name for the active learning parameter,
active_learninginstead ofactivethat causes it to fail under newer versions of VW.