[fix] add single skill from deep-link skills.sh URLs #3
Open
scalfs wants to merge 1 commit intomoldable-ai:mainfrom
Open
[fix] add single skill from deep-link skills.sh URLs #3scalfs wants to merge 1 commit intomoldable-ai:mainfrom
scalfs wants to merge 1 commit intomoldable-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some skills.sh URLs were not being recognized as valid input when adding skill repositories, causing the action to fail silently. This affected both standard repo URLs (https://skills.sh/owner/repo) and deep-link URLs pointing to a specific skill (https://skills.sh/owner/repo/skill).
normalizeRepoInput now returns a structured object
{ repo, skill? }instead of a plain string, correctly parsing both URL formats. When a specific skill is identified via the third path segment, handleAddRepo passes mode: 'include' and skills:[skill]to the API - the backend already supported these parameters, they just weren't being passed.Examples of urls that failed for me:
Before: Some skills.sh URL would fail to be recognized and the skill could not be added
After: Both formats are now accepted. A repo URL installs all skills from that repo, while a deep-link URL installs only the specified skill
