fix: prevent ariadne from panicking on empty stdin/file

bin/src/traits.rs

@@ -52,12 +52,10 @@ fn write_stderr<T: Write>(
     let range = |at: TextRange| at.start().into()..at.end().into();
     let src_id = path.to_str().unwrap_or("<unknown>");
     for report in &lint_result.reports {
-        let offset = report
-            .diagnostics
-            .iter()
-            .map(|d| d.at.start().into())
-            .min()
-            .unwrap_or(0usize);
+        let report_range = report
+            .total_diagnostic_range()
+            .map(range)
+            .unwrap_or(0usize..0usize);
         let report_kind = match report.severity {
             Severity::Warn => CliReportKind::Warning,
             Severity::Error => CliReportKind::Error,
@@ -67,7 +65,7 @@ fn write_stderr<T: Write>(
             .diagnostics
             .iter()
             .fold(
-                CliReport::build(report_kind, src_id, offset)
+                CliReport::build(report_kind, (src_id, report_range))
                     .with_config(
                         CliConfig::default()
                             .with_cross_gap(true)

bin/tests/_utils.rs

@@ -1,7 +1,8 @@
-use std::{io::Write, process::Command};
+use std::{io::Write, process::Command, process::Stdio};
 
 use tempfile::NamedTempFile;
 
+#[allow(dead_code)]
 pub fn test_cli(expression: &str, args: &[&str]) -> anyhow::Result<String> {
     let mut fixture = NamedTempFile::with_suffix(".nix")?;
     fixture.write_all(expression.as_bytes())?;
@@ -19,3 +20,25 @@ pub fn test_cli(expression: &str, args: &[&str]) -> anyhow::Result<String> {
 
     Ok(stdout)
 }
+
+#[allow(dead_code)]
+pub fn test_cli_stdin(input: &str, args: &[&str]) -> anyhow::Result<String> {
+    let mut child = Command::new("cargo")
+        .arg("run")
+        .arg("--")
+        .args(args)
+        .stdin(Stdio::piped())
+        .stdout(Stdio::piped())
+        .spawn()?;
+
+    child
+        .stdin
+        .as_mut()
+        .expect("stdin should be piped")
+        .write_all(input.as_bytes())?;
+
+    let output = child.wait_with_output()?;
+    let stdout = strip_ansi_escapes::strip(output.stdout)?;
+
+    Ok(String::from_utf8(stdout)?)
+}

bin/tests/empty_file.rs

@@ -0,0 +1,10 @@
+mod _utils;
+
+#[test]
+fn check_empty_file_reports_parse_error() {
+    let stdout = _utils::test_cli("", &["check"]).unwrap();
+
+    assert!(stdout.contains("[00] Error: Syntax error"), "{stdout}");
+    assert!(stdout.contains("Unexpected end of file"), "{stdout}");
+    assert!(stdout.contains("<temp_file_path>:1:1"), "{stdout}");
+}

bin/tests/empty_stdin.rs

@@ -0,0 +1,10 @@
+mod _utils;
+
+#[test]
+fn check_empty_stdin_reports_parse_error() {
+    let stdout = _utils::test_cli_stdin("", &["check", "-s"]).unwrap();
+
+    assert!(stdout.contains("[00] Error: Syntax error"), "{stdout}");
+    assert!(stdout.contains("Unexpected end of file"), "{stdout}");
+    assert!(stdout.contains("<stdin>:1:1"), "{stdout}");
+}

bin/tests/snapshots/bool_comparison__01765d342111cdd7f2f68ac70b4a9451_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 true != false
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ true != false
-   · ──────┬──────  
-   ·       ╰──────── Equality comparison between boolean literals
+   │ ──────┬──────  
+   │       ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__3fce60992c69dd4f86be49b4f2898f9e_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 false != true
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ false != true
-   · ──────┬──────  
-   ·       ╰──────── Equality comparison between boolean literals
+   │ ──────┬──────  
+   │       ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__5d2c71eef69cc07e519dc3646f786ba7_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 false == false
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ false == false
-   · ───────┬──────  
-   ·        ╰──────── Equality comparison between boolean literals
+   │ ───────┬──────  
+   │        ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__82b623ef0ecd1e0e70c1dbe39f028326_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 true == true
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ true == true
-   · ──────┬─────  
-   ·       ╰─────── Equality comparison between boolean literals
+   │ ──────┬─────  
+   │       ╰─────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__852249844e4f5e03707d323181ca8645_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 true != true
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ true != true
-   · ──────┬─────  
-   ·       ╰─────── Equality comparison between boolean literals
+   │ ──────┬─────  
+   │       ╰─────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__ba56854c55bd3954b56d4e0c3d32b65c_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 false == true
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ false == true
-   · ──────┬──────  
-   ·       ╰──────── Equality comparison between boolean literals
+   │ ──────┬──────  
+   │       ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__e242c6e0c4298e00ab2cae2f89de63cc_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 false != false
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ false != false
-   · ───────┬──────  
-   ·        ╰──────── Equality comparison between boolean literals
+   │ ───────┬──────  
+   │        ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_comparison__eb450df0fb6d76e9df94f175a6b87a7c_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_comparison.rs
 ---
 true == false
 ---
-[W01] Warning: Equality comparison between boolean literals
-   ╭─[<temp_file_path>:1:1]
+[01] Warning: Equality comparison between boolean literals
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ true == false
-   · ──────┬──────  
-   ·       ╰──────── Equality comparison between boolean literals
+   │ ──────┬──────  
+   │       ╰──────── Equality comparison between boolean literals
 ───╯

bin/tests/snapshots/bool_simplification__b01828755e286c145f9a8ae65cde7a14_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/bool_simplification.rs
 ---
 !(a == b)
 ---
-[W18] Warning: This boolean expression can be simplified
-   ╭─[<temp_file_path>:1:1]
+[18] Warning: This boolean expression can be simplified
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ !(a == b)
-   · ────┬────  
-   ·     ╰────── Try != instead of !(... == ...)
+   │ ────┬────  
+   │     ╰────── Try != instead of !(... == ...)
 ───╯

bin/tests/snapshots/collapsible_let_in__2e638014232f7dec2606c940ad2e97f6_lint.snap

@@ -9,14 +9,16 @@ let
 in
 x
 ---
-[W06] Warning: These let-in expressions are collapsible
-   ╭─[<temp_file_path>:1:1]
+[06] Warning: These let-in expressions are collapsible
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ ╭───▶ let
+   ┆ ┆     
  4 │ │ ╭─▶ let
+   ┆ ┆ ┆   
  7 │ │ ├─▶ x
-   · │ │   │   
-   · │ ╰─────── This let in expression is nested
-   · │     │   
-   · ╰─────┴─── This let in expression contains a nested let in expression
+   │ │ │   │   
+   │ │ ╰─────── This let in expression is nested
+   │ │     │   
+   │ ╰─────┴─── This let in expression contains a nested let in expression
 ───╯

bin/tests/snapshots/collapsible_let_in__950e48dec6590cd20937e48006bff3f7_lint.snap

@@ -11,14 +11,16 @@ in
   in
   a + b + c + d
 ---
-[W06] Warning: These let-in expressions are collapsible
-   ╭─[<temp_file_path>:1:1]
+[06] Warning: These let-in expressions are collapsible
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ ╭───▶ let
+   ┆ ┆     
  5 │ │ ╭─▶   let
+   ┆ ┆ ┆   
  9 │ │ ├─▶   a + b + c + d
-   · │ │                 │   
-   · │ ╰───────────────────── This let in expression is nested
-   · │                   │   
-   · ╰───────────────────┴─── This let in expression contains a nested let in expression
+   │ │ │                 │   
+   │ │ ╰───────────────────── This let in expression is nested
+   │ │                   │   
+   │ ╰───────────────────┴─── This let in expression contains a nested let in expression
 ───╯

bin/tests/snapshots/collapsible_let_in__f9545ef768954a51771885c60c1bca1a_lint.snap

@@ -9,14 +9,16 @@ let
 in
 c
 ---
-[W06] Warning: These let-in expressions are collapsible
-   ╭─[<temp_file_path>:1:1]
+[06] Warning: These let-in expressions are collapsible
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ ╭───▶ let
+   ┆ ┆     
  4 │ │ ╭─▶ let
+   ┆ ┆ ┆   
  7 │ │ ├─▶ c
-   · │ │   │   
-   · │ ╰─────── This let in expression is nested
-   · │     │   
-   · ╰─────┴─── This let in expression contains a nested let in expression
+   │ │ │   │   
+   │ │ ╰─────── This let in expression is nested
+   │ │     │   
+   │ ╰─────┴─── This let in expression contains a nested let in expression
 ───╯

bin/tests/snapshots/collapsible_let_in__fe25e67d93fa84cbd3753185f7f64e63_lint.snap

@@ -9,14 +9,16 @@ let
 in
 x
 ---
-[W06] Warning: These let-in expressions are collapsible
-   ╭─[<temp_file_path>:1:1]
+[06] Warning: These let-in expressions are collapsible
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ ╭───▶ let
+   ┆ ┆     
  4 │ │ ╭─▶ let
+   ┆ ┆ ┆   
  7 │ │ ├─▶ x
-   · │ │   │   
-   · │ ╰─────── This let in expression is nested
-   · │     │   
-   · ╰─────┴─── This let in expression contains a nested let in expression
+   │ │ │   │   
+   │ │ ╰─────── This let in expression is nested
+   │ │     │   
+   │ ╰─────┴─── This let in expression contains a nested let in expression
 ───╯

bin/tests/snapshots/deprecated_to_path__174dc0d1d9e78fd30b854475b82a9917_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/deprecated_to_path.rs
 ---
 builtins.toPath "/some/path"
 ---
-[W17] Warning: Found usage of deprecated builtin toPath
-   ╭─[<temp_file_path>:1:1]
+[17] Warning: Found usage of deprecated builtin toPath
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ builtins.toPath "/some/path"
-   · ──────────────┬─────────────  
-   ·               ╰─────────────── builtins.toPath is deprecated, see :doc builtins.toPath within the REPL for more
+   │ ──────────────┬─────────────  
+   │               ╰─────────────── builtins.toPath is deprecated, see :doc builtins.toPath within the REPL for more
 ───╯

bin/tests/snapshots/deprecated_to_path__4f2c5321b7dbd2171c77729c879745a1_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/deprecated_to_path.rs
 ---
 toPath x
 ---
-[W17] Warning: Found usage of deprecated builtin toPath
-   ╭─[<temp_file_path>:1:1]
+[17] Warning: Found usage of deprecated builtin toPath
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ toPath x
-   · ────┬───  
-   ·     ╰───── toPath is deprecated, see :doc builtins.toPath within the REPL for more
+   │ ────┬───  
+   │     ╰───── toPath is deprecated, see :doc builtins.toPath within the REPL for more
 ───╯

bin/tests/snapshots/deprecated_to_path__b7ca5bc4bbe1fe57468d47f2df8fac29_lint.snap

@@ -3,10 +3,10 @@ source: bin/tests/deprecated_to_path.rs
 ---
 builtins.toPath x
 ---
-[W17] Warning: Found usage of deprecated builtin toPath
-   ╭─[<temp_file_path>:1:1]
+[17] Warning: Found usage of deprecated builtin toPath
+   ╭─[ <temp_file_path>:1:1 ]
    │
  1 │ builtins.toPath x
-   · ────────┬────────  
-   ·         ╰────────── builtins.toPath is deprecated, see :doc builtins.toPath within the REPL for more
+   │ ────────┬────────  
+   │         ╰────────── builtins.toPath is deprecated, see :doc builtins.toPath within the REPL for more
 ───╯