refactor: file matching implementation#2566
Open
sinrohit-desco wants to merge 1 commit intomolybdenumsoftware:masterfrom
Open
refactor: file matching implementation#2566sinrohit-desco wants to merge 1 commit intomolybdenumsoftware:masterfrom
sinrohit-desco wants to merge 1 commit intomolybdenumsoftware:masterfrom
Conversation
Replace hand-rolled Walker iterator and build_ignore_set with ignore::WalkBuilder from the same ignore crate. Earlier we were using ignore::gitignore API for pattern matching and a custom Walker struct for directory traversal. WalkBuilder combines both — it walks directories and applies gitignore rules.
Member
|
How about we replace most of this with usage of some popular and well tested crate, instead? |
Author
Well, do you have any in mind that we could use? |
Member
Author
|
I don't think that this is very good idea. Reasons below
The motivation to use this crate was to simplify things. In my opinion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precursor to #1921