Skip to content

fix: build Universal Binary for Intel CPU support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
momenbasel merged 1 commit into from
Apr 10, 2026
Merged

fix: build Universal Binary for Intel CPU support #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ jobs:
- name: Generate Xcode project
run: xcodegen generate

- name: Build
- name: Build (Universal Binary)
run: |
xcodebuild -project PureMac.xcodeproj \
-scheme PureMac \
-configuration Release \
-derivedDataPath build \
build \
ARCHS="arm64 x86_64" \
CODE_SIGN_IDENTITY="" \
CODE_SIGNING_REQUIRED=NO \
Comment on lines 23 to 30
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCHS is now set in project.yml, and the workflow also forces ARCHS on the command line. This duplication can drift over time; consider relying on the project setting (or alternatively removing it from project.yml and keeping CI as the single source of truth).

Copilot uses AI. Check for mistakes.
CODE_SIGNING_ALLOWED=NO
1 change: 1 addition & 0 deletions project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ settings:
base:
SWIFT_VERSION: "5.9"
MACOSX_DEPLOYMENT_TARGET: "13.0"
ARCHS: "arm64 x86_64"
CODE_SIGN_IDENTITY: "-"
CODE_SIGN_STYLE: "Automatic"
Comment on lines 12 to 16
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting ARCHS at the global settings.base level applies to all configurations (including Debug), which can significantly slow local dev builds by always producing a universal binary. Consider scoping this to Release (or using XcodeGen per-config settings) so Debug can keep the default/active-arch behavior while Release produces the universal app.

Copilot uses AI. Check for mistakes.
DEVELOPMENT_TEAM: "H3WXHVTP97"
Expand Down
Loading