Open
Conversation
…n-power/data-acquisition-system into josephs/wired-module
…s for each sensor with their implementations, now each sensor .chh file is a child of the sensor base
AroshHeenkenda
requested changes
Jul 16, 2025
Contributor
AroshHeenkenda
left a comment
AroshHeenkenda
left a comment
There was a problem hiding this comment.
A few things so we can thorougly test this before any merges.
- I left a comment about using config/.env files, please take a look at that
- Could we please get some steps to test this on our own devices?
- You have a lot of print statements in here which is good, but it would be better if these went to a
.logfile (which would be gitignored), that way we can track what happens on a device accurately.
Log file printing should follow a message format like below:
[yyyy/mm/dd hh:mm:ss] [message_type] log_message
e.g.
[2025/07/17 12:25:00] [INFO] Connected to MQTT service.
Comment on lines
+16
to
+18
| const char* ssid = "A 2 jang pura extn_5G"; | ||
| const char* password = "act12345"; | ||
| const char* mqttServer = "192.168.0.117"; // will replace it later with raspberry's IP |
Contributor
There was a problem hiding this comment.
These shouldn't be written and committed directly into the main file. Instead we should use a .env or some similar type of configuration file. The contents of this file in this case will contain something like the below:
SSID="some_SSID"
PASSWORD="some_password"
MQTT_SERVER="ip_for_server"
The main.cpp will read from this file, the file should also be gitignored so we don't put these secrets onto Git. This way for anyone's test environment they can play around with the values to make it work and it keeps our data confidential. Let me know if you have any questions about this.
… code. Deleted other files to prevent fails. Will gradually debug and test other files from wire_module_arduino and add to this updated one
…rs instead of being hardcoded for the barometer
Unfinished
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed main.cpp and sensor base to connect to wifi and mqtt instead of sending to raspberry via canbus