-
Notifications
You must be signed in to change notification settings - Fork 445
Improve tests of parsers #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests of parsers #586
Conversation
|
In short description:
|
|
Why replace mocks with actual implementations? I mean, I understand the usual reasons, but in this case mocks seem acceptable to me. |
For the usual reasons.. hahaah
Let's not make a big deal out of it.. if this is no good I will revert.. no problem. |
|
Even if we consider replacing mocks with actual implementations, that should be a separate PR, probably covering the whole library. |
|
Revert the test changes about prophesize :) |
sagikazarmark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
before merging #529 if we could merge this first..