-
Notifications
You must be signed in to change notification settings - Fork 228
fix: update collection drawer styles COMPASS-9477 #7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the collection drawer styles in the data modeling component to match a new design. The changes implement a more structured accordion-based layout with improved visual organization and interaction patterns.
- Updates collection drawer to use accordion-style layout with sections for collection details and relationships
- Redesigns relationship management interface with inline edit/delete buttons and improved visual hierarchy
- Adds utility function for generating relationship display names
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/compass-data-modeling/test/fixtures/flights-model.json | Adds a name field to test fixture relationship for testing |
packages/compass-data-modeling/src/utils.ts | Creates utility function for generating relationship display names |
packages/compass-data-modeling/src/components/relationship-drawer-content.tsx | Moves delete button to accordion header and updates styling |
packages/compass-data-modeling/src/components/diagram-editor-side-panel.spec.tsx | Updates tests to match new UI structure and element locations |
packages/compass-data-modeling/src/components/collection-drawer-content.tsx | Complete redesign with accordion layout and improved relationship list |
packages/compass-components/src/components/accordion.tsx | Adds buttonTextClassName prop for additional styling flexibility |
Comments suppressed due to low confidence (1)
packages/compass-data-modeling/src/components/collection-drawer-content.tsx:68
- Using float: 'right' is an outdated CSS practice. Consider using flexbox with justify-content: 'flex-end' or margin-left: 'auto' instead for better maintainability and modern CSS practices.
textOverflow: 'ellipsis',
packages/compass-data-modeling/src/components/relationship-drawer-content.tsx
Outdated
Show resolved
Hide resolved
12ee9ac
to
376cd76
Compare
packages/compass-data-modeling/src/components/collection-drawer-content.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/collection-drawer-content.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/dm-drawer-section.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/dm-drawer-section.tsx
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx
Outdated
Show resolved
Hide resolved
packages/compass-data-modeling/src/components/drawer/collection-drawer-content.tsx
Show resolved
Hide resolved
f0f4ec5
to
920fee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note on the border color, but otherwise looks awesome!
'&:first-child': { | ||
marginTop: `-${spacing[400]}px`, | ||
}, | ||
borderBottom: `1px solid ${palette.gray.light2}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a dark mode color for the border here
Description
The figma for our project is not up to date, Ben has been doing some redesigns as the edit project is crystallizing - but this shouldn't be too far from the final version and at least with this we'll have the main part of the UI ready for internal review on dev.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes