feat(NODE-7166)!: increase napi version to 9 #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
napi-version
branch
from
2f47ff5 to
350ff0b
Compare
baileympearson
commented
Sep 17, 2025
baileympearson
commented
Sep 17, 2025
addaleax
reviewed
Sep 17, 2025
baileympearson
force-pushed
the
napi-version
branch
from
9810421 to
af2113f
Compare
baileympearson
changed the title
baileympearson
force-pushed
the
napi-version
branch
from
4f4b13b to
e19fc7b
Compare
durran
added
the
Primary Review
durran
reviewed
Sep 17, 2025
addaleax
approved these changes
Sep 17, 2025
durran
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR increases the napi version to 9. Additionally, it adds an internal napi C++/ JS function which returns the napi version, just to assert in tests that we are using the correct napi version.
Notes for Reviewers
The webpack tests started failing with this change because
npm iwas trying to install prebuilds for kerberos. The download url for each prebuild includes the napi version, and because we have not yet released a version of kerberos using napi v9, this failed.I resolved this issue by using
--ignore-scripts, which is okay to use here because we don't actually need prebuilds to test the bundling step.What is the motivation for this change?
Release Highlight
kerberos' napi version has been increased to 9
kerberos' napi version has been increased to 9.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript