Skip to content

Conversation

FGasper
Copy link

@FGasper FGasper commented Sep 10, 2025

No description provided.

@FGasper FGasper requested a review from a team as a code owner September 10, 2025 18:06
arch=arm64
esac

urls=$(curl -fsSL https://api.github.com/repos/mongodb-js/mongosh/releases/latest | jq -r '.assets[] | .browser_download_url' | grep -v -e \.sig -e shared -e openssl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use https://downloads.mongodb.com/compass/mongosh.json for this rather than GH

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better, yes. Adjusted jq query accordingly.

@FGasper FGasper requested a review from addaleax September 11, 2025 13:00
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need to have some sort of triage conversation in the team here, we don't typically add this type of feature on a very ad-hoc basis but this does make sense to me to add in general


curl -fsSL "$url" | tar -xzf - \
--transform "s/.*\///" \
--wildcards "**/mongosh"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd probably want mongosh_crypt_v1.so to be extracted next to mongosh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should maybe know this, but: why so? What breaks if it’s not there? (It worked for me without.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic encryption for Queryable Encryption & CSFLE don't – not everybody cares about those, but I don't think we'd like to ship "partially broken" versions of mongosh if we don't need to

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the script now downloads both the executable and the shared library.

FGasper and others added 2 commits September 11, 2025 10:46
Co-authored-by: Anna Henningsen <github@addaleax.net>
Co-authored-by: Anna Henningsen <github@addaleax.net>
@FGasper
Copy link
Author

FGasper commented Sep 11, 2025

@addaleax Triage: by all means. I just wanted to PoC the idea to get the ball rolling.

@addaleax addaleax changed the title Add a download script to facilitate easy use in CI. feat: add a download script to facilitate easy use in CI MONGOSH-2687 Sep 11, 2025
@FGasper FGasper requested a review from addaleax September 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants