-
Notifications
You must be signed in to change notification settings - Fork 79
feat: add a download script to facilitate easy use in CI MONGOSH-2687 #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
download_latest.sh
Outdated
arch=arm64 | ||
esac | ||
|
||
urls=$(curl -fsSL https://api.github.com/repos/mongodb-js/mongosh/releases/latest | jq -r '.assets[] | .browser_download_url' | grep -v -e \.sig -e shared -e openssl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use https://downloads.mongodb.com/compass/mongosh.json for this rather than GH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely better, yes. Adjusted jq query accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we need to have some sort of triage conversation in the team here, we don't typically add this type of feature on a very ad-hoc basis but this does make sense to me to add in general
download_latest.sh
Outdated
|
||
curl -fsSL "$url" | tar -xzf - \ | ||
--transform "s/.*\///" \ | ||
--wildcards "**/mongosh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd probably want mongosh_crypt_v1.so
to be extracted next to mongosh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should maybe know this, but: why so? What breaks if it’s not there? (It worked for me without.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic encryption for Queryable Encryption & CSFLE don't – not everybody cares about those, but I don't think we'd like to ship "partially broken" versions of mongosh if we don't need to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the script now downloads both the executable and the shared library.
Co-authored-by: Anna Henningsen <github@addaleax.net>
Co-authored-by: Anna Henningsen <github@addaleax.net>
@addaleax Triage: by all means. I just wanted to PoC the idea to get the ball rolling. |
No description provided.