Skip to content

DOCSP-38344: remove environment variables from database config file #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

DOCSP-38344: remove environment variables from database config file #7

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8e8f2b
DOCSP-38344: remove environment variables from database config file
Apr 23, 2024
a418177
fix default connection
Apr 23, 2024
3289858
reversal: use env variables instead
Apr 23, 2024
f8f7ef6
Merge branch 'main' into DOCSP-38344-remove-environment-variables
Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions my-app/config/database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
|
*/

'default' => env('DB_CONNECTION', 'mongodb'),
'default' => env('mongodb'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: this syntax causes an error for me when I run a query using DB::collection(). I think you can just directly assign 'mongodb' to 'default':

Suggested change
'default' => env('mongodb'),
'default' => 'mongodb',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thought I had deleted that part. Good catch, will fix!


/*
|--------------------------------------------------------------------------
Expand All @@ -36,7 +36,7 @@
'connections' => [
'mongodb' => [
'driver' => 'mongodb',
'dsn' => env('DB_URI', '<connection string>'),
'dsn' => '<connection string>',
'database' => 'sample_mflix',
],

Expand Down