(EAI-1257) handle multiple correct and more answer options #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakubova92
changed the title
mongodben
reviewed
Aug 29, 2025
Comment on lines
+12
to
+21
| const answers = ["A", "B", "C", "D", "E", "F"] | ||
| .map((label) => { | ||
| const isCorrect = correctAnswers.includes(label); | ||
| return { | ||
| answer: row[label], | ||
| isCorrect, | ||
| label, | ||
| }; | ||
| }) | ||
| .filter((answer) => answer.answer && answer.answer.trim() !== ""); // Remove empty answers |
There was a problem hiding this comment.
i think this code could be a little cleaner. rather than filtering at the end, can you slice the array of ["A", "B", "C", ...] to the correct length before running the map over it?
mongodben
reviewed
Aug 29, 2025
Comment on lines
+10
to
+11
| const handleAnswers = (row: any) => { | ||
| const correctAnswers = row.Answer.trim()?.split("") || []; |
There was a problem hiding this comment.
instead of passing row: any, please make sure that the input is strongly typed. you can use zod to do any validation that you need.
mongodben
reviewed
Aug 29, 2025
Comment on lines
+37
to
+38
| questionType: | ||
| row["Answer"].length > 1 ? "multipleCorrect" : "singleCorrect", |
There was a problem hiding this comment.
consider doing more typesafe parsing rather than checking string length (which isn't very resilient). for example, there could be an err in the spreadsheet
mongodben
reviewed
Aug 29, 2025
| answers, | ||
| explanation: row["Reference"], | ||
| tags: row["tags"] ? row["tags"].split(",") : [], |
There was a problem hiding this comment.
Suggested change
| tags: row["tags"] ? row["tags"].split(",") : [], | |
| tags: row["tags"] ? row["tags"].split(",").map(t => t.trim()) : [], |
again, a bit more resilient
mongodben
requested changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1257
Changes
Notes