(EAI-1274): Rate and comment endpoints based only on message id #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
reviewed
Aug 22, 2025
|
|
||
| export const CommentMessageRequest = SomeExpressRequest.merge( | ||
| export const CommentMessageRequestV2 = SomeExpressRequest.merge( |
There was a problem hiding this comment.
Suggested change
| export const CommentMessageRequestV2 = SomeExpressRequest.merge( | |
| export const CommentStandaloneMessageRequest = SomeExpressRequest.merge( |
nit - I feel like "v2" is not a great naming scheme, especially since this is part of the "v1" API. This name is more descriptive of what the request actually is.
There was a problem hiding this comment.
yea valid, will update *MessageRequestV2 to *StandaloneMessageRequest throughout
nlarew
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1274
Changes
Notes