-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PHPORM-264: Deprecate Mongo soft deletes trait #3408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Conversation
In favor of the Laravel one. Ours is now obsolete; the SoftDeletes trait is only necessary to remove the call to qualifyColumn in the parent trait. But the DocumentModel::qualifyColumn is already disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to docs tests lgtm
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
Sorry this took me so long @GromNaN. Question, why do we trigger an |
|
Gotcha, thank you! |
In favor of the Laravel one. Ours is now obsolete; the SoftDeletes trait is only necessary to remove the call to qualifyColumn in the parent trait. But the DocumentModel::qualifyColumn is already disabled.
Also replaces some internal/test usages with the recommended trait.
Closes PHPORM-264
Checklist