CSHARP-5632: Consolidate driver project Type extension methods in Misc\TypeExtensions.cs #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
added
the
improvement
adelinowona
requested changes
Nov 17, 2025
Contributor
There was a problem hiding this comment.
While we are here, could we also remove the unnecessary else blocks in some of the methods.
Contributor
There was a problem hiding this comment.
Also I noticed that the methods: TryGetIEnumerableGenericInterface; TryGetIListGenericInterface; TryGetIQueryableGenericInterface all have nearly identical implementations. Could they be consolidated to use the existing TryGetGenericInterface helper?
something like:
public static bool TryGetIEnumerableGenericInterface(this Type type, out Type ienumerableGenericInterface)
{
return TryGetGenericInterface(type, new[] { typeof(IEnumerable<>) }, out ienumerableGenericInterface);
}
Contributor
Author
There was a problem hiding this comment.
Done except slightly differently. I added an overload of TryGetGenerricInterface that only takes a single generic interface definition to match against. Should be slightly more efficient than the array version when there is only one definition involved.
adelinowona
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.