CSHARP-5784: Execute dotnet restore with retries on Evergreen #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
added
the
chore
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements retry logic for dotnet restore operations in the Evergreen CI environment to handle transient network failures. The main changes include introducing a new compilation script with retry logic and updating the build pipeline configuration.
- Introduces retry mechanism for dotnet restore with exponential backoff (up to 5 attempts)
- Refactors build pipeline to separate compilation from test execution
- Removes unused build configuration files and Cake build tasks
- Wraps DEBUG-only test assertions with conditional compilation directives for CSOT feature
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| evergreen/compile-sources.sh | New script implementing dotnet restore with retry logic and exponential backoff |
| evergreen/evergreen.yml | Adds compile-sources function and integrates it into all test tasks; removes upload-working-dir function |
| evergreen/run-unit-tests.sh | Updates test command to use Release configuration and removes separate build step |
| tests/MongoDB.Driver.Tests/MongoUrlTests.cs | Wraps CSOT Timeout property tests with DEBUG conditional compilation |
| tests/MongoDB.Driver.Tests/MongoUrlBuilderTests.cs | Wraps CSOT Timeout property tests with DEBUG conditional compilation |
| tests/MongoDB.Driver.Tests/Core/Configuration/ConnectionStringTests.cs | Wraps CSOT Timeout property tests with DEBUG conditional compilation |
| build.cake | Removes Build, Package, and PushToNuGet tasks, keeping only test execution tasks |
| tools/packages.config | Removes Cake dependency configuration file |
| evergreen/set-virtualenv.sh | Removes Python virtual environment setup script |
| evergreen/install-dotnet.sh | Updated path reference in evergreen.yml (not shown in diffs) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BorisDog
requested changes
Nov 18, 2025
|
|
||
| dotnet build | ||
| dotnet test --no-build --filter "Category!=Integration" -f "$FRAMEWORK" --results-directory ./build/test-results --logger "junit;verbosity=detailed;LogFileName=TEST-{assembly}.xml;FailureBodyFormat=Verbose" --logger "console;verbosity=detailed" | ||
| dotnet test -c Release --no-build --filter "Category!=Integration" -f "$FRAMEWORK" --results-directory ./build/test-results --logger "junit;verbosity=detailed;LogFileName=TEST-{assembly}.xml;FailureBodyFormat=Verbose" --logger "console;verbosity=detailed" |
Contributor
There was a problem hiding this comment.
Should execute compile-sources as well?
Member
Author
There was a problem hiding this comment.
As it was discussed: I've reworked the scripts to execute compile-sources.sh from the run-tests.sh
| fi | ||
|
|
||
| DELAY=$((ATTEMPT * RESTORE_RETRY_DELAY_SECONDS_MULTIPLIER)) | ||
| echo "dotnet restore failed. Retrying in $DELAY seconds..." |
Contributor
There was a problem hiding this comment.
nit: Add ATTEMPT in the log message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.