Skip to content

Fix type parameters not being passed to fallback property codec #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type parameters not being passed to fallback property codec #1765

wants to merge 1 commit into from
+3 −1

Conversation

GliczDev
Copy link

For some reason, type parameters weren't passed to fallback property codec, which caused an exception when trying to access them. Now, this issue is fixed.

@GliczDev GliczDev requested a review from a team as a code owner July 11, 2025 00:59
@GliczDev GliczDev requested review from NathanQingyangXu and removed request for a team July 11, 2025 00:59
@NathanQingyangXu
Copy link
Contributor

@rozza , I am not sure about the validity of the code changes proposed. For one thing, it breaks 6 unit testing cases; secondly it seems FallbackPropertyCodecProvider opted for calling CodecRegistry#get(Type) intentionally, for the reason that the other get(Type, List<Type>() might not be overridden, thus defeating the purpose of fallback as the last resort.
How do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanQingyangXu NathanQingyangXu Awaiting requested review from NathanQingyangXu NathanQingyangXu is a code owner automatically assigned from mongodb/dbx-java

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GliczDev @NathanQingyangXu