-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5215 Add an asyncio.Protocol implementation for KMS #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I'm debugging two failures:
|
I realized the benchmark test wasn't actually triggering the protocol -> I'm tweaking things locally |
This has a couple commits from #2467 |
Okay this is ready for a look. We might consider switching to the base |
I still need to make a PR for the fix to the kms mock server's 404 response. |
CSOT failure is unrelated: PYTHON-5492 |
See benchmark gist.
Benchmark Results:
Before:
4.93s, 5.26s
After:
4.80s
,4.89s
Depends on mongodb-labs/drivers-evergreen-tools#679