Skip to content

PYTHON-5215 Add an asyncio.Protocol implementation for KMS #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 6, 2025

See benchmark gist.

Benchmark Results:

Before: 4.93s, 5.26s
After: 4.80s, 4.89s

Depends on mongodb-labs/drivers-evergreen-tools#679

@blink1073 blink1073 requested a review from NoahStapp August 6, 2025 19:30
@blink1073 blink1073 requested a review from a team as a code owner August 6, 2025 19:30
@blink1073
Copy link
Member Author

I'm debugging two failures:

test.asynchronous.test_connection_monitoring.AsyncTestCMAP.test_connection_monitoring_pool_clear_interrupting_pending_connections_clear_with_interruptInUseConnections___true_closes_pending_connections
test.asynchronous.test_connection_monitoring.AsyncTestCMAP.test_connection_monitoring_pool_create_min_size_error_error_during_minPoolSize_population_clears_pool

@blink1073 blink1073 marked this pull request as draft August 7, 2025 00:24
@blink1073 blink1073 removed the request for review from NoahStapp August 7, 2025 00:24
@blink1073
Copy link
Member Author

I realized the benchmark test wasn't actually triggering the protocol -> I'm tweaking things locally

@blink1073
Copy link
Member Author

This has a couple commits from #2467

@blink1073
Copy link
Member Author

Okay this is ready for a look. We might consider switching to the base Protocol since the sizes of the responses are constrained and small, and we typically only have 2-3 reads per socket.

@blink1073 blink1073 requested a review from NoahStapp August 8, 2025 22:07
@blink1073
Copy link
Member Author

I still need to make a PR for the fix to the kms mock server's 404 response.

@blink1073
Copy link
Member Author

CSOT failure is unrelated: PYTHON-5492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant