-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5569: [Build Failure] Spec Resync job is failing silently #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16a485c
catch patch errors and show them in the PR
sleepyStick b8fdcc1
python 3712 was completed (i think)
sleepyStick 313120a
script should exit if fail
sleepyStick ffdaba0
not sure why this was changed? but i think we still need this patch
sleepyStick 4322cc5
ran resync-all-specs
sleepyStick a4664e2
create patch for python 5529
sleepyStick 1042b82
wait these shouldn't have been added back (remove support for mongodb…
sleepyStick 20cb829
wait this shouldn't be here (python 3712)?
sleepyStick fb37dc7
open telemetry stuff (i dont think we do anything for it yet so i'm j…
sleepyStick b1297dd
use recursive find instead of two rms
sleepyStick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
diff --git a/test/discovery_and_monitoring/unified/serverMonitoringMode.json b/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
index 4b492f7d8..e44fad1bc 100644 | ||
index e44fad1b..4b492f7d 100644 | ||
--- a/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
+++ b/test/discovery_and_monitoring/unified/serverMonitoringMode.json | ||
@@ -5,8 +5,7 @@ | ||
@@ -5,7 +5,8 @@ | ||
{ | ||
"topologies": [ | ||
"single", | ||
+ "sharded" | ||
- "sharded", | ||
- "sharded-replicaset" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already did this ticket but for whatever reason the spec repo still has this one instance of |
||
- "sharded" | ||
+ "sharded", | ||
+ "sharded-replicaset" | ||
], | ||
"serverless": "forbid" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should make errors more visible to us