PYTHON-5518: withTransaction API retries too frequently #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepyStick
changed the title
sleepyStick
changed the title
Contributor
|
@sleepyStick is this ready for review? |
Contributor
Author
yes? the spec for these changes are still in review -- if the spec is good/doesn't have any more changes, then this is ready for review? |
NoahStapp
reviewed
Nov 18, 2025
| async def test_transaction_backoff(self): | ||
| client = async_client_context.client | ||
| coll = client[self.db.name].test | ||
| # patch random to make it deterministic |
Contributor
There was a problem hiding this comment.
Why do we need random to be deterministic here? Can you expand this comment with a short motivation?
ShaneHarvey
requested changes
Nov 21, 2025
| @@ -0,0 +1,111 @@ | |||
| from __future__ import annotations | |||
Member
There was a problem hiding this comment.
We don't want to add this file do we?
| @@ -0,0 +1,82 @@ | |||
| from __future__ import annotations | |||
Member
There was a problem hiding this comment.
We don't want to add this file do we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-5518
Summary
_BACKOFF_INITIAL, _BACKOFF_MAX, and the growth rate have now been experimented with using the previous with_transaction benchmark and values are chosen based on what experimentally did the best.
Changes in this PR
added tests for the backoff in with_transaction
changed _BACKOFF_INITIAL, _BACKOFF_MAX, and the growth rate
graph.pywas the file used to analyze the various _BACKOFF_INITIAL, _BACKOFF_MAX, and the growth rate values against each otherwithTransaction.pywas the benchmarking scripthappy to remove them or put them elsewhere but since this is just merging into the backpressure branch, i figured it was fine to keep for now?
Testing Plan
prose test
Screenshots (optional)
Checklist
Checklist for Author
Checklist for Reviewer {@primary_reviewer}
Focus Areas for Reviewer (optional)