test(NODE-7195): migrate integration/crud/find tests
#4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
commented
Oct 13, 2025
Comment on lines
+929
to
+950
| it.skip('should correctly iterate over collection', async function () { | ||
| const db = client.db(this.configuration.db); | ||
|
|
||
| const collection = db.collection('shouldCorrectlyIterateOverCollection'); | ||
| // Insert 500 documents | ||
| const docsToInsert = Array.from({ length: 500 }, () => ({ | ||
| a: 1, | ||
| b: 2, | ||
| c: { d: 3, f: 'sfdsffffffffffffffffffffffffffffff' } | ||
| })); | ||
| await collection.insertMany(docsToInsert); | ||
|
|
||
| let iteratedCount = 0; | ||
| const cursor = collection.find({}); | ||
|
|
||
| for await (const doc of cursor) { | ||
| expect(doc).to.exist; | ||
| iteratedCount++; | ||
| } | ||
|
|
||
| expect(iteratedCount).to.equal(500); | ||
| }).skipReason = 'TODO(NODE-3819): flaky tests (on macOS)'; |
There was a problem hiding this comment.
Even though the test is skipped I took an opportunity to refactor it as well, maybe we can unskip it now as most probably it won't be flaky.
There was a problem hiding this comment.
I'm fine with giving it a try; go for it!
baileympearson
added
the
Primary Review
baileympearson
requested changes
Oct 14, 2025
| }); | ||
| }); | ||
| it('should correctly perform find by $where', { | ||
| metadata: { requires: { mongodb: '4.2.x' } }, |
There was a problem hiding this comment.
4.2 is our lowest tested server version - suggest removing metadata entirely
test/integration/crud/find.test.ts
Outdated
| }); | ||
| }); | ||
| }); | ||
| it('should execute query using limit of 101', async function () { |
There was a problem hiding this comment.
Suggested change
| it('should execute query using limit of 101', async function () { | |
| it('should execute query using limit of 200', async function () { |
we may as well align the title with the test 🤷
| }); | ||
| }); | ||
| } | ||
| it('Should correctly apply db level options to find cursor', async function () { |
There was a problem hiding this comment.
suggest either removing this, or fixing it. as it is written, the test always passes (insert two docs, fetch all docs, assert two docs fetched)
Comment on lines
+929
to
+950
| it.skip('should correctly iterate over collection', async function () { | ||
| const db = client.db(this.configuration.db); | ||
|
|
||
| const collection = db.collection('shouldCorrectlyIterateOverCollection'); | ||
| // Insert 500 documents | ||
| const docsToInsert = Array.from({ length: 500 }, () => ({ | ||
| a: 1, | ||
| b: 2, | ||
| c: { d: 3, f: 'sfdsffffffffffffffffffffffffffffff' } | ||
| })); | ||
| await collection.insertMany(docsToInsert); | ||
|
|
||
| let iteratedCount = 0; | ||
| const cursor = collection.find({}); | ||
|
|
||
| for await (const doc of cursor) { | ||
| expect(doc).to.exist; | ||
| iteratedCount++; | ||
| } | ||
|
|
||
| expect(iteratedCount).to.equal(500); | ||
| }).skipReason = 'TODO(NODE-3819): flaky tests (on macOS)'; |
There was a problem hiding this comment.
I'm fine with giving it a try; go for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR migrates the integration tests for
crud/find. The changes include:srcfolderNotes for Reviewers
To simplify the review process there is a separate commit for .js -> .ts conversion.
What is the motivation for this change?
This work is part of a larger, ongoing initiative to convert all tests to use
async/await, with the ultimate goal of removing the legacy driver wrapper.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript