This repository was archived by the owner on Apr 11, 2020. It is now read-only.
Extracted static decoder and renamed project.#3
Open
hultqvist wants to merge 2 commits intomono:masterfrom
hultqvist:master
Open
Extracted static decoder and renamed project.#3hultqvist wants to merge 2 commits intomono:masterfrom hultqvist:master
hultqvist wants to merge 2 commits intomono:masterfrom
hultqvist:master
Conversation
added 2 commits
June 2, 2012 15:09
Moved example code into Program.
…not clash with the namespace. Set explicit "Microsoft Visual Studio" formatting(in MonoDevelop) to project files, it was specified as "Custom" but did not match the current format.
Member
|
The first change looks good, but the second changes API significantly with almost no need. We wouldn't like to risk users (if any) for extraneous change. |
Author
|
Sounds reasonable, do you want a new pull request with only the first commit or can you pull that one as it is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit extracts the decoder methods to a static class "Decoder".
Then I did not like the generic name and OggDecoder clashed with the namespace so I changed the namespace in the second commit.
Feel free to pull any or all of them.