Conversation
catfact
left a comment
catfact
left a comment
There was a problem hiding this comment.
couple typos broke compilation for me.
apps/bees/config.mk
Outdated
| $(APP_DIR)/src/ops/op_gate.c \ | ||
| $(APP_DIR)/src/ops/op_harry.c \ | ||
| $(APP_DIR)/src/ops/op_hid_word.c \ | ||
| $(APP_DIR)/src/ops/op_hid_word.c \ |
There was a problem hiding this comment.
I have no clue about what is wrong here, but after copying the original version (and again I don't see any difference) it seems to work correctly for me. Therefore I replaced config.mk with the version I had in my computer.
apps/bees/src/op.c
Outdated
| eOpPoly, | ||
| eOpRandom, | ||
| eOpRoute, | ||
| eOpRoute2 |
There was a problem hiding this comment.
this missing comma breaks compilation
There was a problem hiding this comment.
Stupid mistake, sorry about that... It is my first time in here (and I am well aware I am replying to this two months later), and instead of copying my code I rewrote it into github, hence the errors. Now how should this work? I am fine with correcting these of course, but should I do the changes myself or should I simply accept yours?
|
i'm down with renaming ROUTE to ROUTE4 for consistency, both in display and class/enum. shouldn't even break any scenes if order of op class enum/registry remains unchanged. |
corrected line 73, coma missing
Coma missing in line 73 - corrected
Should be fixed by now
Yankow2
left a comment
Yankow2
left a comment
There was a problem hiding this comment.
I think we should go for ROUTE4 then, I am quite bad at working with Github so far but learning... Hope it is all good now, as soon as the changes are in I will post a few scenes for Bees 0.8.1 (or 0.8.2?)
apps/bees/src/op.c
Outdated
| eOpPoly, | ||
| eOpRandom, | ||
| eOpRoute, | ||
| eOpRoute2 |
There was a problem hiding this comment.
Stupid mistake, sorry about that... It is my first time in here (and I am well aware I am replying to this two months later), and instead of copying my code I rewrote it into github, hence the errors. Now how should this work? I am fine with correcting these of course, but should I do the changes myself or should I simply accept yours?
apps/bees/config.mk
Outdated
| $(APP_DIR)/src/ops/op_gate.c \ | ||
| $(APP_DIR)/src/ops/op_harry.c \ | ||
| $(APP_DIR)/src/ops/op_hid_word.c \ | ||
| $(APP_DIR)/src/ops/op_hid_word.c \ |
There was a problem hiding this comment.
I have no clue about what is wrong here, but after copying the original version (and again I don't see any difference) it seems to work correctly for me. Therefore I replaced config.mk with the version I had in my computer.
2 participants
I have added two operators:
I have been using these two for quite a while on my own, and they have proven very useful in bigger scenes mostly - think some others might think the same. Also, it will help me to share some of my scenes, which use those.
By the way, why not change the name Route for Route4, now that we have List2, List4, List8, List16, and then Route2, Route, Route8 and Route16?