Skip to content

sample-transfer that compiles with some caveats#313

Open
prgmsoftware wants to merge 37 commits intomonome:sample-transferfrom
prgmsoftware:dev
Open

sample-transfer that compiles with some caveats#313
prgmsoftware wants to merge 37 commits intomonome:sample-transferfrom
prgmsoftware:dev

Conversation

@prgmsoftware
Copy link
Contributor

this should be the necessary changes, I got it to compile and play a sample with an updated version of the mix module, this module is set as default too for it to work without troubles.

@prgmsoftware prgmsoftware changed the title DO NOT MERGE sample-transfer that compiles with some caveats sample-transfer that compiles with some caveats Mar 24, 2018
@prgmsoftware
Copy link
Contributor Author

prgmsoftware commented Mar 24, 2018

this can now be merged as far as bees is concerned, however it requires that all modules adapt these functions, I have not included these changes to the modules in this pr!

void module_set_offset(ParamValue v) {
; //handle offset from spi
}

void module_set_sample(ParamValue v) {
; //handle sample from spi
}

app_bees.c is not changed anymore, but I have yet to figure out how to remove that remove that file from the pr (sorry!)

@prgmsoftware
Copy link
Contributor Author

prgmsoftware commented Mar 26, 2018

I reverted my ruin of the mix module and added those things in a new test module instead, 'sample'

have found after some tests that recalling a scene looks like an unresolved issue when using samples

so far this works:
load a module, load the samples, edit scene, store scene

this does not work:

  • loading scene and then samples loses the scene
  • loading samples and then a scene loses the samples

I tried to move the parameter data outside the SDRAM struct, but that did not seem to do the trick, will look at it some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments