Skip to content

Conversation

@xmacex
Copy link
Contributor

@xmacex xmacex commented Nov 1, 2025

A change so simple I must be misunderstanding something, and/or placing this in the wrong place. As I understand, the updates are still coming through and doing their thing, just that they aren't printed (DruidRepl.output) into druid for the user to see.

@xmacex xmacex changed the title Do not print updates to the public variables. Fixes 88. Do not print updates to the public variables. Fixes #88 Nov 1, 2025
@tehn
Copy link
Member

tehn commented Nov 1, 2025

i believe this is correct--- i admit to never using public vars myself--- pinging @trentgill for confirmation.

happy to release a new version upon fix

@tehn
Copy link
Member

tehn commented Nov 1, 2025

aha, any chance you saw the only other open PR?

#69

@xmacex
Copy link
Contributor Author

xmacex commented Nov 2, 2025

I did saw it exists, but didn't look closer at it. You are corrent, I see now that it addresses this same thing, and more. Thanks for pointing that out. Would merging PR, or cherrypicking the bits which filter events in crow_event in repl.py and close #88 be possible?

@tehn tehn merged commit 0499b01 into monome:main Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants