Upgrade websockets API (#91) #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error can happen when crow.serial = None, indicating crow is not connected. It might happen in other cases too, but this seems common and mundane enough to mention to the user.
Member
|
thank you for investigating this! confirmed that it's now working. the errors are frustrating, i suspect this could be addressed with configuration options or another exception handler. maybe websocat isn't closing the connection the way it wants? i'll see if i can poke at it and make it a clean fix |
Contributor
Author
|
Yeah I might take another poke at it if I have some more time. I'd like to do some kind of wiresharking to inspect the difference between what causes the errors and what doesn't. Might just be that the library got pickier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades druid's consumption of the websockets API and better handles websocket messages while crow is disconnected.
NB: some errors are still logged when talking to druid with
websocatvialocalhostbut not via127.0.0.1(as described in #91). However, these don't block functionality and also aren't present when using python's websockets, so they are a different issue, possibly nothing to do with druid.