Open
Conversation
Author
|
Here are some additional information for reviewing:
|
Author
|
Here is a blog post describing the logic: How to sort tabs smartly on Firefox addons and Chromium extensions? - Qiita |
|
@piroor Looks like this addon was abandoned by his author. No updates since 2017. :( |
Owner
|
Thank you for the contribution, this is nice work! Also very cool writeup. Indeed I had abandoned the addon for a long time, but am back to it. Need a bit of time to integrate your code better, since I made some rearrangements - there is now a background script, in which the sorting happens. |
ryokash
pushed a commit
to ryokash/sort-tabs-advanced
that referenced
this pull request
Jun 15, 2024
…rtup Made apply autosort on startup + minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Currently this addon tries to move all tabs always, even if they don't need to be moved. This approach may cause some troubles:
So, instead only minimum tabs should be moved based on the algorithm of "diff". This PR contains a ported version of diff and changes to move tabs based on the calculated difference. The main logic is ported from Tree Style Tab, and this PR is based on my another PR for Firefox Multi-Account Containers.
How about this change?