Remove name fixes #209
Open
Remove name fixes #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing casing and naming of variables, functions, and methods is inherently dangerous. We do not know whether: - a method is called externally or must meet a specific externally-controlled naming scheme - a method uses named parameters And plenty of other reasons.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
============================================
- Coverage 98.37% 98.35% -0.02%
+ Complexity 1000 994 -6
============================================
Files 42 42
Lines 3140 3109 -31
============================================
- Hits 3089 3058 -31
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm raising this PR because I've found that the automated fixes for naming conventions can actively break code.
Whilst it is true that some function, method, and variable names do not meet our coding style, sometimes we must follow them for outside reasons. It is simply impossible to keep a complete list of those that need to meet these requirements, and it's not practical to assume that all of these locations specify the
#[\Override]attribute.Sorry @cameron1729