Fix notice due to empty flag parameter

[q0rban]

Simple fix to ensure that the form_unflag_link_leads_to_edit exists when determining the op.

[mooffie]

I'm surprised to see that somebody is looking into this module.

I haven't used Drupal in ages. Does 'flag_form' actually works with D7? It was written when D7 was in alpha stage. There's no point in committing this one-line patch if there are bigger problems with the module.

if you, or anybody, is willing, please take this module (and its associated ones) and maintain it on drupal.org. Frankly, as far as I remember, Flag itself was effectively orphaned. So unless Nate is willing to relinquish control, I don't think investing time in Flag-related modules is a wise thing.

(I won't be able to reply till sunday.)

[q0rban]

Yes, we're using this module in Drupal 7 with lots of success, alongside your patch for fieldable flaggings. I would totally be willing to move it to d.o, except that there already is a flag_form module there. :P

Nate is still plugging away at Flag module, as can be seen by the fact that d.o itself is now using it for issue subscriptions. :)

Sorry to see that you're not working on Drupal stuff lately! You've done a ton of great stuff for the community, so thank you for that. :)

Thanks,
James

[mooffie]

I give you permission to move this module to drupal.org. Be its maintainer. Please allow, and encourage, other developers to be co-maintainers (otherwise this module would die out).

As for the existing 'flag_form' module: I suggest you approach its maintainer and offer him your help in renaming his module. His is a very trivial module. I think 'flag_form' is a very suitable name for "our" module so I'd hate to see it go. HOWEVER, I'll leave it to you to decide; if it doesn't worth your bother to rename the existing module, just find some other sensible name for our module and move forward.

(As for Flag itself: I'm disappointed no other developers have joined the wagon (I'm not sure this phrase exists in English ;-). My opinion is that if Flag doesn't support the basic features of D7/8 (read: entities) then people should let it die out.)

Good luck, James.

[joelstein]

Did this flag_form module ever get put on Drupal.org in any fashion? I can't find it, but I would like to, to offer patches.

[q0rban]

It has not. Feel free to post patches to my fork of it: https://github.com/q0rban/flag_form

[mikkeschiren]

I will gladly put this on drupal.org is an full project.

[mooffie]

@mikkeschiren: Feel free to do so. Once you do, I'll remove this one.

• See my second comment in this discussion, about trying to acquire Drupal.Org's flag_form namespace (but it's not mandatory; you'll just have to rename this module if it's too complex).
• Be liberal in allowing (and offering) capable users to be co-maintainers or even maintainer(s) so this module won't die.

[mikkeschiren]

How do you think in renaming it to flag_forms?

[q0rban]

flagging_form makes sense to me. Please add me as a co-maintainer, and push from my fork as there are bug fixes there.

[mikkeschiren]

Just was going to ask you about the fixes :-)
Flagging form... I do not know, I think it is important to keep the flag part to tell in the name that is related to flag - I am really into semantics ;-)

[mikkeschiren]

Sandbox up, I named it Flag forms, but I will start an issue on the name. http://drupal.org/sandbox/mikkeX/1473530
moffle, I also added you as a maintainer, so that we git commits looks ok, if you want to be removed, please tell.

[mooffie]

I'm leaving it to you people to decide about the name, and about absolutely everything else.

From now on I'll be out of the picture.

(You may drop me an email if you have any questions about the code; although nowadays I'm not "in shape", Drupal wise, so don't expect much.)

I wish you success!

(I won't be at the computer till Sunday.)

[mooffie]

Flagging form... I do not know, I think it is
important to keep the flag part to tell in the
name that is related to flag - I am really into
semantics

BTW, if you look into the file flag_form.module you'll see that I picked the prefix "flag_flagging_" for the form functions there (I left there a comment). That's because these forms deal with the "flagging" entities, and I thought it made sense. Then again, perhaps to others it won't make sense.

Sorry for not posting this in the "sandbox": I'm so out of touch.

Now I'll really be out of the picture ;-) Not another word from me. I don't envy you guys, picking a name, for a module or a baby, isn't the most pleasant task. Good luck.