Skip to content

Fix publishing with BBB #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Jul 23, 2025
Merged

Fix publishing with BBB #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions infra/pub.yml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ write_files:
-v quiet \
-re \
-i /tmp/fragmented.mp4 \
-vf "drawtext=fontfile=/usr/share/fonts/truetype/dejavu/DejaVuSansMono.ttf:text='${region}: %%{gmtime: %%H\\:%%M\\:%%S.%%3N}':x=(W-tw)-24:y=24:fontsize=48:fontcolor=white:box=1:boxcolor=black@0.5" \
-an \
-b:v 3M \
-preset ultrafast \
-tune zerolatency \
-c copy \
-f mp4 \
-movflags cmaf+separate_moof+delay_moov+skip_trailer+frag_every_frame \
- | \
Expand All @@ -60,7 +56,7 @@ write_files:
--cap-add=SYS_PTRACE \
-e RUST_LOG=debug -e RUST_BACKTRACE=1 \
${docker_image} \
hang publish --url "https://relay.quic.video/anon" --name "bbb"'
publish --url https://relay.quic.video/demo?jwt=${demo_token} --name bbb'
Copy link

@cursor cursor bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Command Block Issues with Token Expansion

The bash -c command block now incorrectly encloses the publish command within single quotes, preventing the expansion of ${demo_token} and passing the literal string. Additionally, the hang subcommand was removed. The URL and name parameters are also unquoted, which, combined with the ? in the URL, can lead to shell parsing errors.

Locations (1)

Fix in Cursor • Fix in Web


ExecStop=docker stop hang-bbb

Expand Down