Skip to content

Conversation

@kixelated
Copy link
Collaborator

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Walkthrough

Added a new [features] section to web-transport-ws/Cargo.toml with default = []. Introduced two features: rustls-tls-native-roots = ["tokio-tungstenite/rustls-tls-native-roots"] and rustls-tls-webpki-roots = ["tokio-tungstenite/rustls-tls-webpki-roots"]. No other dependencies or code behavior were changed.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether a description exists and relates to the changeset. Add a description explaining why these rustls features are being proxied and how they should be used by consumers of the web-transport-ws crate.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Proxy the rustls features to tungstunite' directly describes the main change: exposing rustls TLS features from tokio-tungstenite as features in web-transport-ws.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da3f7a1 and 70ac757.

📒 Files selected for processing (1)
  • web-transport-ws/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • web-transport-ws/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit 8244613 into main Jan 14, 2026
1 check passed
@kixelated kixelated deleted the rustls-features branch January 14, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants