Improve the DLL search pattern #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it discover newer versions such as the recently released Vimba 4.0, too.
Owner
|
Thanks, much nicer! My only hesitation is that this requires Python 3.4, which may cut off some users. |
Author
|
Yes, I specifically checked for the patlib library availability. But Python 3.4 is already end of life. Even Python 3.5 will be EOL in september. |
Author
|
The more critical thing, I just realized would be the format strings I used. That is python 3.6. Feel free to use ore modify this code as you like :-) I just ran across it when the current pymba version did not like vimba 4. |
Owner
|
Fair point on v3.4. Yes, the f-strings are still an issue for some users, if you can remove that I'll merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it discover newer versions such as the recently released Vimba 4.0, too.