Skip to content

refactored slice to avoid twice iteration #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

refactored slice to avoid twice iteration #1011

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
352af77
refactored
leandromoh Jul 3, 2023
118b12c
remove empty line
leandromoh Jul 3, 2023
e221209
remove unnessary using
leandromoh Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions MoreLinq/Slice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ namespace MoreLinq
{
using System;
using System.Collections.Generic;
using System.Linq;

public static partial class MoreEnumerable
{
Expand Down Expand Up @@ -57,9 +56,22 @@ public static IEnumerable<T> Slice<T>(this IEnumerable<T> sequence, int startInd
{
IList<T> list => SliceList(list.Count, i => list[i]),
IReadOnlyList<T> list => SliceList(list.Count, i => list[i]),
var seq => seq.Skip(startIndex).Take(count)
_ => SliceDefault()
};

IEnumerable<T> SliceDefault()
{
var lastIndex = startIndex + count;
var index = -1;
foreach (var item in sequence)
{
if (++index >= lastIndex)
yield break;
else if (index >= startIndex)
yield return item;
}
}

IEnumerable<T> SliceList(int listCount, Func<int, T> indexer)
{
var countdown = count;
Expand Down