Don't default isOpen to false if using renderItemsContainer with empty items#38
Open
caguthrie wants to merge 1 commit intomoroshko:masterfrom
Open
Don't default isOpen to false if using renderItemsContainer with empty items#38caguthrie wants to merge 1 commit intomoroshko:masterfrom
caguthrie wants to merge 1 commit intomoroshko:masterfrom
Conversation
caguthrie
changed the title
Author
|
Also, if this is merged, can a version please be cut so I can raise a PR into react-autosuggest. In addition to the version bump in the package.json and the code snippet in the above issue I will put in react-autosuggest, some tests in react-autosuggest will need to be changed as they expect the items container to be closed when there are no suggestions, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses this Github issue in react-autosuggest: moroshko/react-autosuggest#486
If a
renderItemsContaineris provided,isOpenis true. We may want the items container to be open even if there are norenderedItems.I literally used the code change that @moroshko suggested, and added the requisite tests.