make Listener.canonical a staticmethod, this make the call from callabacks easier.#520
Open
paolopas wants to merge 3 commits intomoses-palmer:masterfrom
Open
make Listener.canonical a staticmethod, this make the call from callabacks easier.#520paolopas wants to merge 3 commits intomoses-palmer:masterfrom
paolopas wants to merge 3 commits intomoses-palmer:masterfrom
Conversation
this make the call from callabacks easier.
Author
|
One last thing I suggest is to uniform the on_activate callback of HotKey to the same protocol of other events callback (i.e. on_press and on_release). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the script tools/keyboard-mixin-test.py as a proof of the concept.
Tested with Linux (xorg).
But I was unable to run the tests, sorry.