Skip to content

Conversation

@antony
Copy link

@antony antony commented Apr 18, 2016

I've been using this in my own project for a while but I thought it was due a pull request.

I like to be able to develop locally and also not hammer the google API during tests, so this allows a simple override of the gmaps api url using config.

@fabriziomoscon
Copy link
Collaborator

fabriziomoscon commented May 9, 2016

It looks like a good idea.
Could you squash all your commits in 1

git rebase -i HEAD^^^
# replace pick with f for the commit you want to change
git commit --amend
git push origin master -f

Because you are making changes to the config I think these should be reported in the README. Could you please add some instructions on how to do add a custom url. I am curious to know how did you mock the Google map API server.

@evansiroky
Copy link
Contributor

I do a similar thing where I send in a custom request function to GoogleMapsAPI constructor. The custom request function sends back mock result data on disk similar to how the unit tests work.

@antony
Copy link
Author

antony commented Jun 24, 2016

Hey @fabriziomoscon will do - sorry I only just saw this.

Btw did you know that github can squash commits now? The merge button above can be dropped down to choose 'squash and merge' :)

@fabriziomoscon
Copy link
Collaborator

@moshen I think squash and merge is an option that administrators can enable:
https://github.com/blog/2141-squash-your-commits#whats-changing
would you mind enable the checks from the admin page please?

@antony
Copy link
Author

antony commented Jun 29, 2016

I've added the docs which should help you @fabriziomoscon understand how I mock the API in my own applications, but also provide help to others wanting to do something similar.

If you don't have squash+merge enabled I can squash it tonight ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants