fixed multiple paths #149
Open
fixed multiple paths #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the path array each next path must be transformed to &path=
The first path is transformed correctly but each next path is not.
Removing the .join('|') will fix this bug.
See https://developers.google.com/maps/documentation/static-maps/intro#URL_Parameters
-> Feature Parameters -> path:
"path (optional) defines a single path of two or more connected points to overlay on the image at specified locations. This parameter takes a string of point definitions separated by the pipe character (|). You may supply additional paths by adding additional path parameters. Note that if you supply a path for a map, you do not need to specify the (normally required) center and zoom parameters. For more information, see Google Static Maps API Paths below."
-> "You may supply additional paths by adding additional path parameters." and so each URL parameter "path" has the following format:
&path=
|
the unit test for parsePathsTest is failing, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the path array each next path must be transformed to &path=
The first path is transformed correctly but each next path is not.
Removing the .join('|') will fix this bug.
See https://developers.google.com/maps/documentation/static-maps/intro#URL_Parameters
-> Feature Parameters -> path:
"path (optional) defines a single path of two or more connected points to overlay on the image at specified locations. This parameter takes a string of point definitions separated by the pipe character (|). You may supply additional paths by adding additional path parameters. Note that if you supply a path for a map, you do not need to specify the (normally required) center and zoom parameters. For more information, see Google Static Maps API Paths below."
-> "You may supply additional paths by adding additional path parameters." and so each URL parameter "path" has the following format:
&path=