MOSIP-43582

[ckm007]

Summary by CodeRabbit

• Chores
  • Standardized build configuration version management across services for consistency and easier maintenance.
  • Enhanced development environment with additional debugging utilities and remote debugging support.

[coderabbitai]

Walkthrough

The changes centralize the Spring Boot Maven Plugin version (3.2.3) into a reusable Maven property across four POM files in the admin module, and add diagnostic and debugging utilities to the kernel-syncdata-service Dockerfile along with JDWP remote debugging configuration.

Changes

Cohort / File(s)	Summary
Maven Plugin Version Centralization admin/admin-service/pom.xml, admin/hotlist-service/pom.xml, admin/kernel-masterdata-service/pom.xml, admin/kernel-syncdata-service/pom.xml	Added new Maven property spring.boot.maven.plugin.version set to 3.2.3 in properties section. Replaced all hard-coded spring-boot-maven-plugin version declarations (3.2.3) with property reference ${spring.boot.maven.plugin.version} in main build plugins and openapi-doc-generate-profile configurations.
Dockerfile Debugging Enhancements admin/kernel-syncdata-service/Dockerfile	Introduced new build-time layer installing debugging utilities: bash, curl, wget, vim, tcpdump, net-tools, iputils, bind-tools, busybox-extras, strace, lsof. Added JDWP remote debugging configuration via JAVA_TOOL_OPTIONS environment variable. Fixed formatting by adding trailing newline.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Repetitive pattern across four POM files makes review straightforward; each follows identical structure for property extraction and replacement
• Dockerfile utilities addition is standard configuration change; JDWP setup is well-established debugging approach
• No complex logic, interdependencies, or architectural changes

Poem

🐰 Four POMs aligned with one pure thought,
A springboot version centrally wrought!
In syncdata's Docker, debug tools abound,
JDWP whispers make troubleshooting sound,
Config so tidy, consistency found! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'MOSIP-43582' is a ticket identifier rather than a descriptive summary of the changes; it does not convey what was actually modified.	Use a descriptive title summarizing the main change, such as 'Centralize Spring Boot Maven Plugin version across services' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch MOSIP-43582-develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c99ba88 and d6e22dc.

📒 Files selected for processing (5)

• admin/admin-service/pom.xml (3 hunks)
• admin/hotlist-service/pom.xml (3 hunks)
• admin/kernel-masterdata-service/pom.xml (3 hunks)
• admin/kernel-syncdata-service/Dockerfile (1 hunks)
• admin/kernel-syncdata-service/pom.xml (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Analyze (java-kotlin)
• GitHub Check: build-maven-admin-services / maven-build
• GitHub Check: build-maven-apitest-masterdata / maven-build
• GitHub Check: apitest-masterdata / build-dockers
• GitHub Check: publish_to_nexus_apitest / publish-to-nexus

🔇 Additional comments (4)

admin/hotlist-service/pom.xml (1)

25-25: Centralized Maven property for Spring Boot plugin version.

The introduction of spring.boot.maven.plugin.version property and its consistent application across the main build and openapi-doc-generate-profile sections improves maintainability and aligns with the broader centralization effort across modules.

Also applies to: 247-247, 442-442

admin/kernel-syncdata-service/pom.xml (1)

26-26: Centralized Maven property for Spring Boot plugin version.

The consistent introduction and application of the spring.boot.maven.plugin.version property across main and profile sections aligns well with the centralization effort across the admin module.

Also applies to: 341-341, 516-516

admin/kernel-masterdata-service/pom.xml (1)

25-25: Centralized Maven property for Spring Boot plugin version.

The property introduction and consistent usage across build sections maintains uniformity across the admin services and improves version governance.

Also applies to: 344-344, 533-533

admin/admin-service/pom.xml (1)

32-32: Centralized Maven property for Spring Boot plugin version.

Consistent introduction of the spring.boot.maven.plugin.version property and its application across main and openapi-doc-generate-profile sections aligns with the PR's centralization objectives.

Also applies to: 260-260, 347-347