-
Notifications
You must be signed in to change notification settings - Fork 126
Added error messages for bulk upload invalid delimiter [MOSIP-27141] #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.3.x
Are you sure you want to change the base?
Conversation
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
WalkthroughA new translation entry Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
artifacts/src/i18n/admin-i18n-bundle/i18n/hin.json (1)
1420-1420: Hindi phrasing is fine; consider a more common termOptional: swap “सीमांकक” with “विभाजक” for wider familiarity.
- "ADM-BLK-010" : "अमान्य सीमांकक का उपयोग किया गया", + "ADM-BLK-010" : "अमान्य विभाजक का उपयोग किया गया",artifacts/src/i18n/admin-i18n-bundle/i18n/kan.json (1)
1431-1431: Kannada wording: optional native termIf you prefer native wording over the loanword, consider:
- "ADM-BLK-010" : "ಅಮಾನ್ಯವಾದ ಡಿಲಿಮಿಟರ್ ಬಳಸಲಾಗಿದೆ", + "ADM-BLK-010" : "ಅಮಾನ್ಯ ವಿಭಾಜಕವನ್ನು ಬಳಸಲಾಗಿದೆ",artifacts/src/i18n/admin-i18n-bundle/i18n/es.json (1)
1302-1302: Spanish phrasing OK; optional refinementConsider one of these slightly more standard variants:
- “Se ha utilizado un delimitador no válido”
- “Se usó un delimitador no válido”
Also, you can drop the space before the colon for consistency.
- "ADM-BLK-010" : "Se utilizó un delimitador no válido", + "ADM-BLK-010": "Se ha utilizado un delimitador no válido",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
artifacts/src/i18n/admin-i18n-bundle/i18n/ara.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/eng.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/es.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/fra.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/hin.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/kan.json(1 hunks)artifacts/src/i18n/admin-i18n-bundle/i18n/tam.json(1 hunks)
🔇 Additional comments (4)
artifacts/src/i18n/admin-i18n-bundle/i18n/fra.json (1)
1571-1571: Translation is correct; ignore space-before-colon suggestionVerification confirms all JSON is valid, ADM-BLK-010 appears exactly once per locale, and the space before the colon is the consistent pattern throughout the codebase (all 7 locale files follow this convention). The suggested refactor to remove the space contradicts the actual codebase style.
Likely an incorrect or invalid review comment.
artifacts/src/i18n/admin-i18n-bundle/i18n/eng.json (1)
1301-1301: Localization entry for invalid delimiter error added correctly.The new error code
ADM-BLK-010with message "Invalid delimiter used" is properly positioned in theserverErrorobject following the existingADM-BLK-009entry. JSON syntax and structure are valid.artifacts/src/i18n/admin-i18n-bundle/i18n/ara.json (1)
1352-1352: Arabic localization entry for invalid delimiter error added correctly.The new error code
ADM-BLK-010with Arabic translation "تم استخدام فاصل غير صالح" is properly positioned and follows the same structure as the English entry. JSON syntax is valid.artifacts/src/i18n/admin-i18n-bundle/i18n/tam.json (1)
1429-1429: Tamil localization entry for invalid delimiter error added correctly.The new error code
ADM-BLK-010with Tamil translation "தவறான வரம்புக் குறி பயன்படுத்தப்பட்டது" is properly positioned and maintains consistency with the English and Arabic entries. JSON syntax is valid.
Summary by CodeRabbit