Skip to content

[MOSIP-43648] Configure graceful pod termination with lifecycle hooks #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckm007 merged 3 commits into from
Nov 16, 2025
Merged

[MOSIP-43648] Configure graceful pod termination with lifecycle hooks #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cdaad0
Update .gitignore
Ivanmeneges Nov 16, 2025
4a20e1a
Update deployment.yaml
Ivanmeneges Nov 16, 2025
518b83b
[MOSIP-43648] Configure graceful pod termination with lifecycle hooks
Ivanmeneges Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/artifactory/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
charts/
Chart.lock
Copy link

@JanardhanBS-SyncByte JanardhanBS-SyncByte Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifactory-ref-impl/deploy
/install.sh CHART_VERSION=1.3.0-beta.2-develop
change to
CHART_VERSION=1.3.0-develop

1 change: 1 addition & 0 deletions helm/artifactory/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ spec:
{{- if .Values.hostAliases }}
hostAliases: {{- include "common.tplvalues.render" (dict "value" .Values.hostAliases "context" $) | nindent 8 }}
{{- end }}
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds | default 60 }}
{{- if .Values.affinity }}
affinity: {{- include "common.tplvalues.render" ( dict "value" .Values.affinity "context" $) | nindent 8 }}
{{- else }}
Expand Down
16 changes: 13 additions & 3 deletions helm/artifactory/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,17 @@ podAnnotations: {}

## lifecycleHooks for the container to automate configuration before or after startup.
##
lifecycleHooks: {}
lifecycleHooks:
preStop:
exec:
command:
- sh
- -c
- sleep 30

## Termination grace perios : the maximum amount of time (in seconds) Kubernetes will wait for a container to gracefully shut down
terminationGracePeriodSeconds: 60

## Custom Liveness probes for
##
customLivenessProbe: {}
Expand Down Expand Up @@ -273,8 +283,8 @@ volumePermissions:
enabled: false
image:
registry: docker.io
repository: bitnami/bitnami-shell
tag: "10"
repository: mosipid/os-shell
tag: "12-debian-12-r46"
pullPolicy: Always
## Optionally specify an array of imagePullSecrets.
## Secrets must be manually created in the namespace.
Copy link

@JanardhanBS-SyncByte JanardhanBS-SyncByte Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repository: mosipid/artifactory-server
tag: 1.3.0-beta.2

change to
repository: mosipqa/artifactory-server
tag: 1.3.x
and

javaOpts: "-Xms750M -Xmx750M"
change to
javaOpts: "-Xms1200M -Xmx1200M"

Expand Down