MOSIP-34689 Fixed notification issue #1596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
ashok-ksharma
approved these changes
Jan 24, 2025
ckm007
reviewed
Jan 27, 2025
Member
ckm007
left a comment
ckm007
left a comment
There was a problem hiding this comment.
In this case if it is build time dependency and someone wants to share their own customised implementation for notifier, how to proceed?
Contributor
Author
i think still notifier can have customized implementation because apart from kernel-smsserviceprovider-msg91 many other mosip modules also having build dependency and sasi already told to remove all runtime dependency and add to pom.xml |
Contributor
Author
|
mosip/artifactory-ref-impl#1027 created another PR as these changes need discussion with team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.