license folder #1780
license folder #1780
Conversation
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
WalkthroughThe PR adds a comprehensive set of open-source license files (Apache 2.0, BSD 2-Clause, CDDL 1.1, EPL 1.0, EPL 2.0, MIT) along with a NOTICE file documenting third-party component copyrights and their corresponding license terms. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Fix all issues with AI Agents 🤖
In @licenses/BSD-2-Clause.txt:
- Line 1: The file name 'licenses/BSD-2-Clause.txt' contains a trailing
invisible character; rename it to 'licenses/BSD-2-Clause.txt' (remove the
zero-width/special char) and commit the rename so tooling/CI sees the corrected
name; update any references in the repo (docs, build scripts, license manifests)
to the cleaned name and run a quick repo-wide check for other filenames
containing zero-width characters to prevent recurrence.
In @licenses/COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txt:
- Line 1: The filename contains a spelling mistake:
"COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txt" should be renamed to
"COMMON-DEVELOPMENT-AND-DISTRIBUTION-1.1.txt"; update the repository to rename
that file (and any references to it in docs/build/config) to the corrected name
so license tooling and references pick up the official "Common Development and
Distribution License 1.1" spelling.
In @licenses/NOTICE:
- Line 34: The NOTICE references license texts that are missing from the
licenses/ folder; add plain-text license files named exactly MPL-2.0.txt,
LGPL-2.1.txt, and GPL-2.0-with-classpath-exception.txt containing the full text
of the Mozilla Public License 2.0, the GNU Lesser General Public License v2.1,
and the GNU General Public License v2.0 with the Classpath Exception
respectively so the entries referenced in NOTICE (lines mentioning "Mozilla
Public License 2.0", "GNU Lesser General Public License 2.1", and "GNU General
Public License 2.0 with Classpath Exception") have corresponding license files
for compliance.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
licenses/Apache-2.0.txtlicenses/BSD-2-Clause.txtlicenses/COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txtlicenses/EPL-1.0.txtlicenses/EPL-2.0.txtlicenses/MIT.txtlicenses/NOTICE
🧰 Additional context used
🪛 LanguageTool
licenses/EPL-2.0.txt
[style] ~22-~22: Consider a more concise word here.
Context: ...iles of the Program solely in each case in order to link to, bind by name, or subclass the ...
(IN_ORDER_TO_PREMIUM)
[grammar] ~33-~33: Use a hyphen to join words.
Context: ... needed, if any. For example, if a third party patent license is required to allo...
(QB_NEW_EN_HYPHEN)
[style] ~39-~39: Consider replacing this phrase with the adverb “reasonably” to avoid wordiness.
Context: ...and informs Recipients how to obtain it in a reasonable manner on or through a medium customarily used...
(IN_A_X_MANNER)
[style] ~40-~40: Did you mean ‘different from’? ‘Different than’ is often considered colloquial style.
Context: ...e the Program under a license different than this Agreement, provided that such lice...
(DIFFERENT_THAN)
[style] ~52-~52: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...are may accept certain responsibilities with respect to end users, business partners and the li...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~52-~52: Consider a more concise word here.
Context: ...ged intellectual property infringement. In order to qualify, an Indemnified Contributor mus...
(IN_ORDER_TO_PREMIUM)
[style] ~69-~69: Consider a more concise word here.
Context: ...istribute copies of this Agreement, but in order to avoid inconsistency the Agreement is co...
(IN_ORDER_TO_PREMIUM)
licenses/Apache-2.0.txt
[style] ~161-~161: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...ge, computer failure or malfunction, or any and all other commercial damages or losse...
(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
🔇 Additional comments (5)
licenses/MIT.txt (1)
3-5: Verify the copyright date accuracy, particularly the 2025 date.The MIT.txt file lists QOS.ch with a copyright extending to 2025. Please verify this date is intentional and accurate, as future-dated copyrights are unusual.
licenses/EPL-2.0.txt (1)
1-80: LGTM!This is the standard Eclipse Public License v2.0 text. License texts are legal documents and should be kept verbatim to maintain legal validity. The static analysis style suggestions should be ignored as they apply to prose writing, not legal license texts.
licenses/NOTICE (1)
1-140: Well-structured NOTICE file with comprehensive third-party attributions.The format is consistent and properly attributes all third-party components with copyright notices and license references. The structure grouping related components (e.g., Apache projects, Spring ecosystem) aids readability.
licenses/EPL-1.0.txt (1)
1-73: LGTM!This is the standard Eclipse Public License v1.0 text. The license is properly formatted and complete.
licenses/Apache-2.0.txt (1)
1-201: LGTM!This is the standard Apache License, Version 2.0 text with the appendix explaining how to apply the license. The content matches the official Apache Software Foundation license text.
| @@ -0,0 +1,9 @@ | |||
| Copyright © 1997-present PostgreSQL Global Development Group | |||
There was a problem hiding this comment.
Remove the special/invisible character at the end of the filename.
The filename licenses/BSD-2-Clause.txt contains a trailing special character (zero-width space or similar) that is not visible but could cause issues with file references, tooling, CI/CD, and cross-platform compatibility. Rename to licenses/BSD-2-Clause.txt (plain ASCII, no trailing special characters).
🤖 Prompt for AI Agents
In @licenses/BSD-2-Clause.txt around line 1, The file name
'licenses/BSD-2-Clause.txt' contains a trailing invisible character; rename it
to 'licenses/BSD-2-Clause.txt' (remove the zero-width/special char) and commit
the rename so tooling/CI sees the corrected name; update any references in the
repo (docs, build scripts, license manifests) to the cleaned name and run a
quick repo-wide check for other filenames containing zero-width characters to
prevent recurrence.
| @@ -0,0 +1,11 @@ | |||
| Common Development and Distribution License 1.1 | |||
There was a problem hiding this comment.
Fix the filename typo: "DEVLOPMENT" → "DEVELOPMENT".
The filename COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txt contains a spelling error. It should be COMMON-DEVELOPMENT-AND-DISTRIBUTION-1.1.txt to match the official license name and standard conventions. This typo can cause issues with compliance tooling, documentation references, and license matching.
🤖 Prompt for AI Agents
In @licenses/COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txt around line 1, The
filename contains a spelling mistake:
"COMMON-DEVLOPMENT-AND-DISTRIBUTION-1.1.txt" should be renamed to
"COMMON-DEVELOPMENT-AND-DISTRIBUTION-1.1.txt"; update the repository to rename
that file (and any references to it in docs/build/config) to the corrected name
so license tooling and references pick up the official "Common Development and
Distribution License 1.1" spelling.
|
|
||
| H2 Database Engine | ||
| Copyright © 2004-present Thomas Müller | ||
| Licensed under the Eclipse Public License 1.0 OR Mozilla Public License 2.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
echo "=== License files present in licenses/ directory ==="
fd . licenses/ --type f | sortRepository: mosip/commons
Length of output: 288
🏁 Script executed:
echo "=== Checking NOTICE file content around specified lines ==="
sed -n '32,36p' licenses/NOTICE
echo "---"
sed -n '80,84p' licenses/NOTICE
echo "---"
sed -n '116,120p' licenses/NOTICERepository: mosip/commons
Length of output: 694
Add missing license text files for compliance.
The NOTICE file references licenses that lack corresponding text files in the licenses/ folder:
- Line 34 (H2): "Mozilla Public License 2.0" – add
MPL-2.0.txt - Line 82 (Logback): "GNU Lesser General Public License 2.1" – add
LGPL-2.1.txt - Lines 118-119 (JavaBeans Activation): "GNU General Public License 2.0 with Classpath Exception" – add
GPL-2.0-with-classpath-exception.txt
🤖 Prompt for AI Agents
In @licenses/NOTICE around line 34, The NOTICE references license texts that are
missing from the licenses/ folder; add plain-text license files named exactly
MPL-2.0.txt, LGPL-2.1.txt, and GPL-2.0-with-classpath-exception.txt containing
the full text of the Mozilla Public License 2.0, the GNU Lesser General Public
License v2.1, and the GNU General Public License v2.0 with the Classpath
Exception respectively so the entries referenced in NOTICE (lines mentioning
"Mozilla Public License 2.0", "GNU Lesser General Public License 2.1", and "GNU
General Public License 2.0 with Classpath Exception") have corresponding license
files for compliance.
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.