[DSD-9138] modified json-form-builder package (#796)

[gk-XL7]

Summary by CodeRabbit

• Chores
  • Updated Docker build environment to Node.js 18-alpine
  • Migrated form builder dependency to latest maintained package version

[coderabbitai]

Walkthrough

The PR migrates the json-form-builder dependency from the @anushase scope to @mosip scope across package configuration, source imports, and documentation. Additionally, the Docker base image is upgraded from Node 12.18.4 to Node 18. No functional logic changes.

Changes

Cohort / File(s)	Summary
Docker Configuration signup-ui/Dockerfile	Base image updated from node:12.18.4-alpine to node:18-alpine for the first build stage
Dependency & Documentation Updates signup-ui/package.json, signup-ui/README.md	Dependency replaced: @anushase/json-form-builder → @mosip/json-form-builder (^0.1.0-beta.0); documentation references updated to reflect new package scope
Source Code Imports signup-ui/src/pages/SignUpPage/AccountSetup/AccountSetup.tsx, signup-ui/src/typings/types.ts	Import paths updated from @anushase/json-form-builder to @mosip/json-form-builder for JsonFormBuilder and FormConfig types; minor formatting adjustments in type unions

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Dependency migration is mechanical and consistent across all touched files
• No behavioral or logic changes; purely import path and configuration updates
• Docker version bump is a straightforward base image change

Poem

🐰 From @anushase to @mosip we hop,
The form builder package takes a new top,
Node twelve was quaint, but eighteen's the way,
Dependencies dance, and imports now play!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing the json-form-builder dependency from @anushase to @mosip scope across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dcd591 and e6f77fb.

⛔ Files ignored due to path filters (1)

• signup-ui/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

• signup-ui/Dockerfile (1 hunks)
• signup-ui/README.md (2 hunks)
• signup-ui/package.json (1 hunks)
• signup-ui/src/pages/SignUpPage/AccountSetup/AccountSetup.tsx (1 hunks)
• signup-ui/src/typings/types.ts (3 hunks)

🔇 Additional comments (7)

signup-ui/README.md (1)

81-84: LGTM!

Documentation correctly updated to reflect the new @mosip/json-form-builder package name, consistent with the dependency change in package.json.

signup-ui/src/typings/types.ts (3)

1-1: Import path updated consistently with the package migration.

The FormConfig type import has been updated from @anushase/json-form-builder/dist/types to @mosip/json-form-builder/dist/types, which aligns with the dependency change in package.json.

Ensure that the FormConfig type exported by @mosip/json-form-builder is compatible with the previous version. Any changes to the type structure could break the application at runtime.

---

109-116: Formatting change only; no semantic impact.

The union type members have been reformatted with each member on a separate line. This improves readability but does not change the type's behavior.

---

205-206: Formatting change only; no semantic impact.

The union type members have been reformatted with each member on a separate line. This improves readability but does not change the type's behavior.

signup-ui/src/pages/SignUpPage/AccountSetup/AccountSetup.tsx (1)

2-3: Import update verified; API compatibility confirmed.

The imports have been successfully updated from @anushase/json-form-builder to @mosip/json-form-builder. All three API methods are present and used correctly:

1. JsonFormBuilder factory function (lines 170-195): Called with config object, container ID, and options; returns form instance ✓
2. render() method (line 196): Exists and is invoked on the form instance ✓
3. updateLanguage() method (line 72): Exists with the correct signature accepting language and label parameters ✓

No API incompatibilities detected.

signup-ui/Dockerfile (1)

1-1: Let me verify a couple of specific dependencies that might have concerns:

Add engines field to package.json to declare Node.js 18 requirement.

React Scripts 5.0.1 supports Node.js 18, and your dependencies (React 18.2.0, TypeScript 4.9.5, Craco 7.1.0, Webpack 5.94.0) are modern versions that support Node 18. However, package.json has an optional engines field that allows you to specify the version of node your code works on. Add to signup-ui/package.json:

"engines": {
  "node": ">=18.0.0",
  "npm": ">=9.0.0"
}

This declares the minimum supported versions and prevents accidental use of incompatible Node versions during builds or deployments.

signup-ui/package.json (1)

12-12: Verify that API compatibility is confirmed and application is properly tested with @mosip/json-form-builder@0.1.0-beta.0.

The new dependency is a beta version (0.1.0-beta.0), which carries inherent instability risks. While package-lock.json has been properly updated and the package is legitimately published on npm, you must confirm:

1. The API of @mosip/json-form-builder is compatible with the previous @anushase/json-form-builder@^1.1.8 (same exports, method signatures, behavior)
2. Thorough integration testing has been completed with this beta package in your application
3. The migration from @anushase to @mosip does not introduce breaking changes in your signup flow

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}